linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Bastien Nocera <hadess@hadess.net>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input - ntrig_spi: add new driver for the Surface 3
Date: Thu, 12 May 2016 12:56:38 -0700	[thread overview]
Message-ID: <20160512195638.GC25805@dtor-ws> (raw)
In-Reply-To: <20160512195122.GX23234@mail.corp.redhat.com>

On Thu, May 12, 2016 at 09:51:22PM +0200, Benjamin Tissoires wrote:
> On May 12 2016 or thereabouts, Dmitry Torokhov wrote:
> > On Thu, May 12, 2016 at 05:07:54PM +0200, Benjamin Tissoires wrote:
> > > +static int __maybe_unused ntrig_spi_suspend(struct device *dev)
> > > +{
> > > +	struct spi_device *spi = to_spi_device(dev);
> > > +	struct ntrig *data = spi_get_drvdata(spi);
> > > +
> > > +	ntrig_spi_free_irq(data);
> > 
> > Why?
> 
> To disable the IRQ and be sure we won't wake up the device...
> It might just work without though.

Or you can do disable_irq(). Do you want it to be wakeup source by
chance? Then you need to wire it up some more.

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2016-05-12 19:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12 15:07 [PATCH] Input - ntrig_spi: add new driver for the Surface 3 Benjamin Tissoires
2016-05-12 19:16 ` Dmitry Torokhov
2016-05-12 19:51   ` Benjamin Tissoires
2016-05-12 19:55     ` Bastien Nocera
2016-05-12 19:56     ` Dmitry Torokhov [this message]
2016-05-13 15:02     ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160512195638.GC25805@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hadess@hadess.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).