From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751931AbcEMEHK (ORCPT ); Fri, 13 May 2016 00:07:10 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:37307 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbcEMEHI (ORCPT ); Fri, 13 May 2016 00:07:08 -0400 Date: Fri, 13 May 2016 06:06:53 +0200 From: Andrew Lunn To: Sergei Shtylyov Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , grant.likely@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, netdev@vger.kernel.org, frowand.list@gmail.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-kernel@vger.kernel.org, Linus Walleij Subject: Re: [PATCH RFT 1/2] phylib: add device reset GPIO support Message-ID: <20160513040653.GA24461@lunn.ch> References: <81129033.NXiOLTg1so@wasted.cogentembedded.com> <3641492.klKRrvS8tr@wasted.cogentembedded.com> <20160512184233.GJ30822@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >>+ gpiod = fwnode_get_named_gpiod(&child->fwnode, "reset-gpios"); > >>+ /* Deassert the reset signal */ > >>+ if (!IS_ERR(gpiod)) > >>+ gpiod_direction_output(gpiod, 0); > > > >This is wrong I think. You must only ignore -ENODEV, all other error > > At least -ENOSYS should also be ignored (it's returned when > gpiolib is not configured), right? When does -ENODEV gets returned > (it's not easy to follow)? > > >codes should be passed to the caller. > > The caller doesn't care anyway... It should do. What if fwnode_get_named_gpiod() returns -EPROBE_DEFER because the GPIO driver has not been loaded yet? Andrew