From: Ladislav Michl <ladis@linux-mips.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Javier Martinez Canillas <javier@dowhile0.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/2] ARM: dts: igep0020: Add SD card write-protect pin.
Date: Fri, 13 May 2016 14:37:18 +0200 [thread overview]
Message-ID: <20160513123718.GA2841@localhost.localdomain> (raw)
In-Reply-To: <1462568554-7868-2-git-send-email-enric.balletbo@collabora.com>
Hi Enric!
On Fri, May 06, 2016 at 11:02:34PM +0200, Enric Balletbo i Serra wrote:
> A host device that supports write protection should refuse to write to
> an SD card that is designated read-only when write-protect is set. This
> is an optional feature of the SD specification.
Does it ever work on any IGEPv2? I have similar patch in my repo and there
is no difference when enabling write protection on SD card. Also schemantics
shows GPIO29 constantly pulled up with a resistor. Is there any board
revision with working WP? I'm just curious as patch is of course correct.
Best regards,
ladis
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> arch/arm/boot/dts/omap3-igep0020-common.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-igep0020-common.dtsi b/arch/arm/boot/dts/omap3-igep0020-common.dtsi
> index d6f839c..b697106 100644
> --- a/arch/arm/boot/dts/omap3-igep0020-common.dtsi
> +++ b/arch/arm/boot/dts/omap3-igep0020-common.dtsi
> @@ -194,6 +194,12 @@
> OMAP3630_CORE2_IOPAD(0x25f8, PIN_OUTPUT | MUX_MODE4) /* etk_d14.gpio_28 */
> >;
> };
> +
> + mmc1_wp_pins: pinmux_mmc1_cd_pins {
> + pinctrl-single,pins = <
> + OMAP3630_CORE2_IOPAD(0x25fa, PIN_INPUT | MUX_MODE4) /* etk_d15.gpio_29 */
> + >;
> + };
> };
>
> &i2c3 {
> @@ -250,3 +256,8 @@
> };
> };
> };
> +
> +&mmc1 {
> + pinctrl-0 = <&mmc1_pins &mmc1_wp_pins>;
> + wp-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>; /* gpio_29 */
> +};
next prev parent reply other threads:[~2016-05-13 12:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 21:02 [PATCH 1/2] ARM: dts: igep00x0: Add SD card-detect Enric Balletbo i Serra
2016-05-06 21:02 ` [PATCH 2/2] ARM: dts: igep0020: Add SD card write-protect pin Enric Balletbo i Serra
2016-05-06 21:07 ` Javier Martinez Canillas
2016-05-13 12:37 ` Ladislav Michl [this message]
2016-05-17 8:06 ` Enric Balletbo Serra
2016-05-06 21:07 ` [PATCH 1/2] ARM: dts: igep00x0: Add SD card-detect Javier Martinez Canillas
2016-05-06 21:22 ` Enric Balletbo i Serra
2016-05-06 21:27 ` Javier Martinez Canillas
2016-05-12 20:53 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160513123718.GA2841@localhost.localdomain \
--to=ladis@linux-mips.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=javier@dowhile0.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).