From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752237AbcENMuV (ORCPT ); Sat, 14 May 2016 08:50:21 -0400 Received: from mail-bn1bon0092.outbound.protection.outlook.com ([157.56.111.92]:31280 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751363AbcENMuR (ORCPT ); Sat, 14 May 2016 08:50:17 -0400 Authentication-Results: arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=none action=none header.from=caviumnetworks.com; Date: Sat, 14 May 2016 15:49:50 +0300 From: Yury Norov To: Arnd Bergmann CC: "Zhangjian (Bamvor)" , Catalin Marinas , , Andrew Pinski , , Hanjun Guo , , , , "jijun (D)" , , , , , , , , , , Andrew Pinski , , , Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Message-ID: <20160514124950.GA27841@yury-N73SV> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <2733875.IzutTZKHMc@wuerfel> <57347BD4.8010105@huawei.com> <4521594.dSmlmmAdFg@wuerfel> <20160512131948.GA30205@yury-N73SV> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160512131948.GA30205@yury-N73SV> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: AM2PR03CA0027.eurprd03.prod.outlook.com (10.160.207.37) To SN1PR07MB2239.namprd07.prod.outlook.com (10.164.47.145) X-MS-Office365-Filtering-Correlation-Id: ef7d81ac-93fb-41f7-ec1a-08d37bf64a82 X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2239;2:zM5+E0Ukqhxb5CMjZeEN6CovYhjMswPRse+w80OLaEE9LhB6p70DE9RcH3ArWwudLMzHz+Zwg+PFwyKvLSs4an7Bjxzxl+HLXcBzq707yV9dIjv9e19UauzPHmX+X+fIIPf1/V3WxWgeoOvHoEKgZw8Rp9f9baoHE/mCgbjNBJzD0GUv2R9H59a6XC5HXiav;3:Z4glwl4eMgCRXa35+o+K6yUnk0sUNJBuwF3SZ8/Y3l94cyVYsZumtTC4PmkKbIDupsUriaZ2aSAjWw9CNhwce8qPMeW4vtB0dDE2UzMpRafg8afbzJTKYlI8zwc2oLQT X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2239; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2239;25:u3kJq37cP+Q1dBJvPv5qW5ygWHGKs07wTDb9mjWPZGuFvr/gEmBs01uF/AvN9Ai2dzYX3x0NpN9tqp4iNTVpJz252EFxNIsd2fHk//l985WiAEo9aZ7zNvPj9Gre9g8OhiOf3NKXJZa1SZKA8GLAe+Ur7NzPc6+uFuVbTcBTS255yhq/sR0ZFxK6xricEKvC8Hj3Ef4eH4+fcAE6tMchgTw/xIzbtQGXjltvY87BdEN8MCGcCJ9iT3/vTc77siAd/K0tXeLXqvmLbN9xDU2VHpP1AIVFhbhzTULaleb5jYtScWM1EkkVqUDQE4YGkuDbxCMRHe1xV5fSsOy8mNSxfaTpBZBkM14wDVQg6po1+T5l0pZJtr7RN/NvR/6+c3F+i6Djg/8Zb3tTSCbx8MIWJVvT2Wu5cNJAGCQ+boALIdSht0rReAFsaZhE3T++gZfFshIhCu3Tf2b8wN+XDX7MB5OuSV4JPY9z5EQmLIk6bWhFasx/XTLcP4cWWndk7UPuFZgpI5bRvE5eVn10Ckdur64NxoZg72k/aavVdzuAgM6UqDA0H2rrJ2WqTORvIggxEc2kPew+v72V6KsnYH050aJf7+Sp1sfgdr4P+u3WisRFPfACcUrC0kVqVsho+vJtwHaqFft/XOw6fU14NIMk+wfqTYKXTYjg3dP/iwCbkh3HaHjsc1WPiMBxcJxUtuPLC9zy8aoeeoeYb5JCtz+F9kDqALiWmy1WPh1cKuO7quo+/j1/22C/vV/AeUwbdu2pAALExG4dJ+ErPTALcv8Quw== X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2239;20:cffVrR4nstYlxFfIm8EtjxWzPapwug5ZwVtoIY38hcYvwHb71kkoxJDta7sfvA4kZdMUZDSYg+lKLg47p34pA7uCJl9Y+eIGeEnRxGUlq0blLDwDTR3FZqjOKjUSD6qBzU+S0V7p2SZlyOmgDwBCjAwtPIe489Re8WBm3YvLJhxVUo/lw4RLz0Eq2MF3SiC17+QRFv/cs7V60ufphjmB464lJwinJUs4zUs5O9/H2cc7j71H5Ogt50ywY1o0mrjbiNwUZolPgchY7wghLyHiK+HkZS2d2J9DC5KZkzZqhuEAqjNc+OzxWf3ina7aqOoCB+Dsy2rtSJybob5UykOnD9hbnsKgWUiZqwu6NHsBdDdl3cA6+CCvH6R1SE+3fw95HdqamxojItAxuKmJL3xATVCQqRIrTQsAE7GXnCXxjtImUSN6PvE0o8/TxsHhcuESuH+hxO3FbIZhfHQ+Nc+m1q9eZ++bPSYHCD/9g/JnPAQrnjR0zoy5Q6xxwJnSR4FsCzBilebOdvVpVvDvTTEvcsqR6enZqc7gPfSlK9m3o9WOFsLDt/5FttjIUaHx3+HdnVX+cZ8aDecWaF+AaJJP+UAuf3abbtpwqZV2W+arRI4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:SN1PR07MB2239;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2239; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2239;4:T+aA2mzSStCR+SuhikssbySWUqdnks30yeNiechnh8iKWdG/y1mF7ypYhn10poqVpS+VH9IUj8hAo+nNYHVOH+Of0Q0+3KBW0eTstS8LMbpyJDUDwIMh7clVxpm8yGcUIqTXmDXvVnNfArvrSN3pbZEwcUaUdmsDKOTubuleiWGukDyWv5Cs3JFyWXRW9bMnMp3U2dHKyq2/g2PS8SMT7r06AEp7B19RpGsmVStbCNGn7vtbH6bUtzzu14Ih0WI3sVv4n4FE7wXOKXAYFEnPY8KC6WTpBEuozpW0xxsp5Z4CDc5Znrillr0c4vKUQYHymF1cJCcQRdaux0zqsyo54ZVbGU3/uAb7hx9eH5NuLgIbj3eVQH6JtKnLeMfsrqm7 X-Forefront-PRVS: 094213BFEA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(51444003)(24454002)(4326007)(2950100001)(575784001)(8676002)(33656002)(189998001)(5890100001)(46406003)(4001350100001)(2906002)(50466002)(93886004)(81166006)(77096005)(586003)(9686002)(97756001)(5008740100001)(3846002)(54356999)(50986999)(76176999)(76506005)(92566002)(6116002)(66066001)(19580405001)(42186005)(19580395003)(110136002)(5004730100002)(47776003)(33716001)(1076002)(23726003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2239;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR07MB2239;23:St4n2/6GhToH7EgMdyQnllSpMtv/N7P9u6/NeIrtf?= =?us-ascii?Q?Qh77C62OYlpqULJo//4t14kFRglLYPXbbE5ow5dmF7Tb9169UAbdXNkbnaxY?= =?us-ascii?Q?3E9XeTYxolT2pBNQLlvg/xk5v3bf5WCLM++TLYXkCpC7IntMnQibPy5oFhed?= =?us-ascii?Q?TnU7wpv14gDEWd+FQxP900F+o+KI+H9c/EhNJTNzJC2yWd74X7UZJVGd2Auy?= =?us-ascii?Q?4sy7Tr4P5OblzGWaELIqwEldGBh49XxRweaY2Xgpl5alpDIzZUay0QaNGG7t?= =?us-ascii?Q?U6N6XxNjiBZm3dvXXM7/XyCSlCyJ0gcmYf4/WMsl0PE8h2AUNaLEf0UA8Vw/?= =?us-ascii?Q?nZykkkDvYaGgCi/utKuLfAa/BWMZQrF/EsknodFIAEF1aAJPEqLUli4A4QrJ?= =?us-ascii?Q?iMB3niOGGQh7GAo2dSAJPOpmRUik2fxiSKLuFNCCNvSCGtIUpbMP4plLYwsq?= =?us-ascii?Q?9/wuFRFWtnsxc7uADSqZLk/odA5uHA6eUB923tAOqpfXdmsd1G1iIUJq8IhD?= =?us-ascii?Q?tQdCXgBB4yhPvUw+x4Tfj9QBOFnREwLA6TJLM3M0eUJ2i2VhaBlfLFZVOYU/?= =?us-ascii?Q?Srko6jA4nzKhurTliboxnr1fbCSHgVwOCAsBIZioSiAoujxPEnKj2xfH7Mjw?= =?us-ascii?Q?mxuXQQZeCEhsGfFjfpWhM7ey8aMcDoF3xpXBK1eXeBlnJAzOsYwT6+Fo9an8?= =?us-ascii?Q?2UoGotK54JA89TalyEdV4nLa2tJmtes3jnc8XK3gi10D24L89g5kTsx+6mRs?= =?us-ascii?Q?DmZDBmV86YqqQgKETWUqf8AMGcBGGHiYjLLv6ugq+3dy1X6jNlXdvZsBC5sG?= =?us-ascii?Q?//wyW2hpErNDMAe0pSSr5FxTy/+l1CF6JefTjN5qCJzXhZf/ZHiK6enForUj?= =?us-ascii?Q?NR/CvrKPY5o5wIT3vAAXljbKy/Pug4Bbl0R5Mhnps8aCvJ+HZ9XMf4bzIZya?= =?us-ascii?Q?f9y+6vZlW7WIaWsch2bDaZdjy458uxQiLSfF6nK2RxAfyhZkI/OcfnrJhDvd?= =?us-ascii?Q?klpOIGEPV8zRZ1prDsk7hMHOWnljQNOmT5GjJKm/Sqsa0mUy3O23j9957Yv2?= =?us-ascii?Q?NX9nW4=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2239;5:LKUVZGocxJzvhMtlOjx0c/AYmsrZSFYu1KI0eFcJn+FXGd4D9R1MoKZQ9Q+GxQi4B+lrOItaahiUN8CZodRFrH61OP/Fa6NB8KPe29hPjTx2r4gOwGlqhj8N+JbkRq7IGdn7TJZaN8d5UWyG4h6r1Q==;24:ZipFObFXL5zhRiO6wNC6c3lDwqO3z7U8KZRC57N1/9W6Dt1vcocAj4gJ+c3cWrAS1+8b3CO9cyCF5XU1UvEhTjarBPjoMMLlCEI9+qOeT20=;7:n9UnnzpM+thWJrF1X3YbHxJDm0TR6HH7chxNjIUo6IJFF6vNtK8hf/RQOFqFlYC0BZUp/JV+NK2qWvOItmHzeuMD+eChWE7w4UoeaiPirXvbj7jIZnVBDP7BWoM+EQFh3HPBKThMLPXOThuRmRsRcRQedNfLBUT72/oBSqJ2wRmCjD9WgbCi6cAAGOqVkDtz SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2016 12:50:12.7574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2239 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 04:19:48PM +0300, Yury Norov wrote: [...] > > I think that's a good idea. The function used to be slightly different > > for each architecture, but now it seems we have a significant number > > of identical implementations that we could just merge them together > > into one. > > > > sys_mmap_pgoff was originally introduced as the common implementation > > and it reduced the amount of duplication a lot, but as its units > > are based on PAGE_SIZE rather than hardwired 4096 bytes, it's > > not as useful. > > > > microblaze and mips (twice) are doing like this. And aarh32 as well, > in arch/arm64/kernel/entry32.S > > In previous submissions it was a patch that shares aarch32 code to > ilp32. If we decided turn around again, I think, we'd pick up that patch. > > The other option is to make this hack generic, as so many arches use it. Hi again, I picked up that old patch from Jan, and found that it doesn't delouse addr and length, which is wrong for ilp32. So now I think we'd pick Bamvor version. Jan's patch (rebased) is attached for reference. Yury. >>From 02ad258662c40d457ac041634e67e1cbdbb800f3 Mon Sep 17 00:00:00 2001 From: Jan Dakinevich Date: Tue, 3 Nov 2015 02:30:41 +0300 Subject: ilp32: common 32-bit wrappers Signed-off-by: Jan Dakinevich Signed-off-by: Yury Norov diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile index 9dfdf86..2319042 100644 --- a/arch/arm64/kernel/Makefile +++ b/arch/arm64/kernel/Makefile @@ -30,6 +30,7 @@ arm64-obj-$(CONFIG_AARCH32_EL0) += sys32.o kuser32.o signal32.o \ ../../arm/kernel/opcodes.o binfmt_elf32.o arm64-obj-$(CONFIG_ARM64_ILP32) += binfmt_ilp32.o arm64-obj-$(CONFIG_FUNCTION_TRACER) += ftrace.o entry-ftrace.o +arm64-obj-$(CONFIG_COMPAT) += entry32-common.o arm64-obj-$(CONFIG_MODULES) += arm64ksyms.o module.o arm64-obj-$(CONFIG_ARM64_MODULE_PLTS) += module-plts.o arm64-obj-$(CONFIG_PERF_EVENTS) += perf_regs.o perf_callchain.o diff --git a/arch/arm64/kernel/entry32-common.S b/arch/arm64/kernel/entry32-common.S new file mode 100644 index 0000000..1a0abe3 --- /dev/null +++ b/arch/arm64/kernel/entry32-common.S @@ -0,0 +1,23 @@ +#include +#include + +#include +#include +#include +#include + +/* + * Note: off_4k (w5) is always in units of 4K. If we can't do the + * requested offset because it is not page-aligned, we return -EINVAL. + */ +ENTRY(compat_sys_mmap2_wrapper) +#if PAGE_SHIFT > 12 + tst w5, #~PAGE_MASK >> 12 + b.ne 1f + lsr w5, w5, #PAGE_SHIFT - 12 +#endif + b sys_mmap_pgoff +1: mov x0, #-EINVAL + ret +ENDPROC(compat_sys_mmap2_wrapper) + diff --git a/arch/arm64/kernel/entry32.S b/arch/arm64/kernel/entry32.S index f332d5d..58cb5b0 100644 --- a/arch/arm64/kernel/entry32.S +++ b/arch/arm64/kernel/entry32.S @@ -55,21 +55,6 @@ ENTRY(compat_sys_fstatfs64_wrapper) ENDPROC(compat_sys_fstatfs64_wrapper) /* - * Note: off_4k (w5) is always in units of 4K. If we can't do the - * requested offset because it is not page-aligned, we return -EINVAL. - */ -ENTRY(compat_sys_mmap2_wrapper) -#if PAGE_SHIFT > 12 - tst w5, #~PAGE_MASK >> 12 - b.ne 1f - lsr w5, w5, #PAGE_SHIFT - 12 -#endif - b sys_mmap_pgoff -1: mov x0, #-EINVAL - ret -ENDPROC(compat_sys_mmap2_wrapper) - -/* * Wrappers for AArch32 syscalls that either take 64-bit parameters * in registers or that take 32-bit parameters which require sign * extension.