From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754176AbcEOLQ6 (ORCPT ); Sun, 15 May 2016 07:16:58 -0400 Received: from dougal.metanate.com ([90.155.101.14]:14147 "EHLO metanate.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752550AbcEOLQ5 (ORCPT ); Sun, 15 May 2016 07:16:57 -0400 Date: Sun, 15 May 2016 12:16:39 +0100 From: John Keeping To: Heiko Stuebner Cc: iommu@lists.linux-foundation.org, Joerg Roedel , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, ZhengShunQian Subject: Re: [PATCH] iommu/rockchip: fix zap cache during device attach Message-ID: <20160515111638.GA9715@river> References: <20160510155046.24515-1-john@metanate.com> <11003810.ccjcAXkzhi@phil> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11003810.ccjcAXkzhi@phil> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 14, 2016 at 10:19:43PM +0200, Heiko Stuebner wrote: > Am Dienstag, 10. Mai 2016, 16:50:46 schrieb John Keeping: > > rk_iommu_command() takes a struct rk_iommu and iterates over the slave > > MMUs, so this is doubly wrong in that we're passing in the wrong pointer > > and talking to MMUs that we shouldn't be. > > > > Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi > > slaves") Signed-off-by: John Keeping > > on a rk3288-veyron > Tested-by: Heiko Stuebner > Reviewed-by: Heiko Stuebner > > I was wondering for a short time why this didn't spew warnings until I > realized that the iommu->bases[i] is of course a void* . Yes, although sparse catches it because iommu->bases[i] is __iomem so it shows up as a namespace warning.