From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555AbcEPHbs (ORCPT ); Mon, 16 May 2016 03:31:48 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34518 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbcEPHbr (ORCPT ); Mon, 16 May 2016 03:31:47 -0400 Date: Mon, 16 May 2016 09:31:44 +0200 From: Michal Hocko To: Christoph Lameter Cc: Arnd Bergmann , Andrew Morton , Hugh Dickins , Vlastimil Babka , Mel Gorman , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: unhide vmstat_text definition for CONFIG_SMP Message-ID: <20160516073144.GA23146@dhcp22.suse.cz> References: <1462978517-2972312-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 11-05-16 10:32:11, Christoph Lameter wrote: > Subject: Do not build vmstat_refresh if there is no procfs support > > It makes no sense to build functionality into the kernel that > cannot be used and causes build issues. > > Signed-off-by: Christoph Lameter > > Index: linux/mm/vmstat.c > =================================================================== > --- linux.orig/mm/vmstat.c > +++ linux/mm/vmstat.c > @@ -1358,7 +1358,6 @@ static const struct file_operations proc > .llseek = seq_lseek, > .release = seq_release, > }; > -#endif /* CONFIG_PROC_FS */ > > #ifdef CONFIG_SMP > static struct workqueue_struct *vmstat_wq; This doesn't work because it makes the whole vmstat_wq depend on CONFIG_PROC_FS. Which is obviously bad because we both rely on doing the periodic sync even when counters are not exported to the userspace and it wound't compile anyway... -- Michal Hocko SUSE Labs