From: Lee Jones <lee.jones@linaro.org>
To: Keerthy <a0393675@ti.com>
Cc: Keerthy <j-keerthy@ti.com>,
broonie@kernel.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCH v2 2/3] mfd: lp873x: Add lp873x PMIC support
Date: Tue, 17 May 2016 09:01:30 +0100 [thread overview]
Message-ID: <20160517080130.GG17238@dell> (raw)
In-Reply-To: <57350E17.3000209@ti.com>
On Fri, 13 May 2016, Keerthy wrote:
> On Thursday 12 May 2016 06:48 PM, Lee Jones wrote:
> >On Tue, 10 May 2016, Keerthy wrote:
> >
> >>The LP873X chip is a power management IC for Portable Navigation Systems
> >> and Tablet Computing devices. It contains the following components:
> >>
> >> - Regulators.
> >> - Configurable General Purpose Output Signals(GPO).
> >>
> >>PMIC interacts with the main processor through i2c. PMIC has
> >>couple of LDOs(Linear Regulators), couple of BUCKs (Step-Down DC-DC
> >>Converter Cores) and GPOs(General Purpose Output Signals). At this
> >>time only the regulator functionality is made available.
> >>
> >>Signed-off-by: Keerthy <j-keerthy@ti.com>
> >>---
> >>
> >>Changes in v2:
> >>
> >> * Used mfd_add_devices instead of of_pltaform_populate.
> >
> >Didn't see this conversation, but of_platform_populate () is usually
> >okay?
>
> https://lkml.org/lkml/2016/5/6/244.
Did Mark tell you why you shouldn't be using it?
> >> drivers/mfd/Kconfig | 15 +++
> >> drivers/mfd/Makefile | 2 +
> >> drivers/mfd/lp873x.c | 98 +++++++++++++++++
> >> include/linux/mfd/lp873x.h | 265 +++++++++++++++++++++++++++++++++++++++++++++
> >> 4 files changed, 380 insertions(+)
> >> create mode 100644 drivers/mfd/lp873x.c
> >> create mode 100644 include/linux/mfd/lp873x.h
[...]
> >>+/**
> >>+ * struct lp873x - state holder for the lp873x driver
> >>+ * Device data may be used to access the LP873X chip
> >>+ */
> >>+struct lp873x {
> >>+ struct device *dev;
> >>+ unsigned long id;
> >>+ u8 rev;
> >>+ struct mutex lp873_lock; /* lock guarding the data structure */
> >>+ struct regmap *regmap;
> >
> >Are all of these used in >1 driver?
>
> Apart from id and rev all are used.
Then why are id and rev in there?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-05-17 8:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 4:04 [PATCH v2 0/3] mfd: lp873x: Add lp873x PMIC support Keerthy
2016-05-10 4:04 ` [PATCH v2 1/3] Documentation: mfd: LP873X: Add information for the mfd and regulator drivers Keerthy
2016-05-11 14:35 ` Rob Herring
2016-05-12 13:21 ` Lee Jones
2016-05-12 23:21 ` Keerthy
2016-05-10 4:04 ` [PATCH v2 2/3] mfd: lp873x: Add lp873x PMIC support Keerthy
2016-05-12 13:18 ` Lee Jones
2016-05-12 23:13 ` Keerthy
2016-05-17 8:01 ` Lee Jones [this message]
2016-05-17 8:04 ` Keerthy
2016-05-17 8:07 ` Keerthy
2016-05-10 4:04 ` [PATCH v2 3/3] regulator: lp873x: Add support for lp873x PMIC regulators Keerthy
2016-05-11 17:27 ` Applied "regulator: lp873x: Add support for lp873x PMIC regulators" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517080130.GG17238@dell \
--to=lee.jones@linaro.org \
--cc=a0393675@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).