From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754340AbcEQKSQ (ORCPT ); Tue, 17 May 2016 06:18:16 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35088 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbcEQKSP (ORCPT ); Tue, 17 May 2016 06:18:15 -0400 Date: Tue, 17 May 2016 11:18:08 +0100 From: Mark Brown To: Linus Torvalds Cc: Linux Kernel Mailing List , Liam Girdwood Message-ID: <20160517101808.GB8104@sirena.org.uk> References: <20160516122706.GK2953@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hHWLQfXTYDoKhP50" Content-Disposition: inline In-Reply-To: X-Cookie: FORCE YOURSELF TO RELAX! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [GIT PULL] regulator updates for v4.7 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hHWLQfXTYDoKhP50 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 16, 2016 at 07:38:23PM -0700, Linus Torvalds wrote: > On Mon, May 16, 2016 at 5:27 AM, Mark Brown wrote: > > Mark Brown (26): > > regulator: Deprecate regulator_can_change_voltage() > This needs to be fixed. > It causes a build warning, and it's just not acceptable. We've had > driver subsystems do this before, and then the warning stays around > for years and nothing gets done. > The warning is not just ugly, it ends up often hiding real problems > when people get used to seeing warnings during the build. I agree, it's not great, I wouldn't normally do it and it's certainly not good to just shove the annotation on there with no other action. In this case a combination of this and pushing patches at people seems to be working - I am expecting all the broken users to be fixed during the merge window (-next looks OK) at which point I can send a patch to you dropping the API. > The whole "__deprecated" crap has been a bigger problem in itself than > it has ever actually solved. > So don't do it. Either remove bad interfaces or leave them alone. None > of this "let's annoy everybody else with our deprecation messages > whether they care about it or not". I was also trying to remove the users via other means so I could delete the function. The reason I added the warning was that all the users were in the embedded graphics drivers and for whatever reason it's historically been suprisingly difficult to get any attention on issues there that don't show up during the build so I hoped this would help push things along faster and avoid new attempts to use it. Like I say something seems to have worked better this time around, though I don't know how much of it is down to the warning of course. I'll send a patch either deleting the interface or reverting this after -rc1 (or earlier if the users are gone from your tree before then) if that's OK? --hHWLQfXTYDoKhP50 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXOu/eAAoJECTWi3JdVIfQOloH/2WLnLD1BA29pVbQ4WgJRSnp yYRRbW9RludR4qiT0nSJNm4o45i7Ibs5F6ecKEhWuK6C2p6Tt/U/ktKEXqoAlvQQ Uzd2TWMITD4U+Ae4K9u5qNnqyIsWxbweyldpbCcAwK2eeyUtq3juEyYRjrRFGBSM vNulzyZGVu6qHh0flEFJyXAWC4eXzkmqO9Oox67qMJ2essdduD7gFbuE2XObFQzL nXe2TeL/474XzvjaX2VpTf77Hx7r+fV0wXBLQcfEC7VwChL08Ma2Y6yEjVQwCJ3I 8Jl1FJX9mnx1dlvOSi1TYzigifP0OzGdSYl/u1kEFe8SnNfHi9jmd59G6uNMj9M= =cCyf -----END PGP SIGNATURE----- --hHWLQfXTYDoKhP50--