From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com, f.fainelli@gmail.com,
jiri@resnulli.us
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: remove bridge work
Date: Tue, 17 May 2016 18:03:58 +0200 [thread overview]
Message-ID: <20160517160358.GC26948@lunn.ch> (raw)
In-Reply-To: <87r3d01yok.fsf@ketchup.mtl.sfl>
On Tue, May 17, 2016 at 11:39:23AM -0400, Vivien Didelot wrote:
> Hi David,
>
> David Miller <davem@davemloft.net> writes:
>
> > From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> > Date: Fri, 13 May 2016 21:28:28 -0400
> >
> >> Hi David,
> >>
> >> Vivien Didelot <vivien.didelot@savoirfairelinux.com> writes:
> >>
> >>> Now that the bridge code defers the switchdev port state setting, there
> >>> is no need to defer the port STP state change within the mv88e6xxx code.
> >>> Thus get rid of the driver's bridge work code.
> >>>
> >>> This also fixes a race condition where the DSA layer assumes that the
> >>> bridge code already set the unbridged port's STP state to Disabled
> >>> before restoring the Forwarding state.
> >>>
> >>> As a consequence, this also fixes the FDB flush for the unbridged port
> >>> which now correctly occurs during the Forwarding to Disabled transition.
> >>>
> >>> Fixes: 0bc05d585d38 ("switchdev: allow caller to explicitly request attr_set as deferred")
> >>> Reported-by: Andrew Lunn <andrew@lunn.ch>
> >>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> >>
> >> This patch doesn't apply to -net, only applies to net-next...
> >>
> >> How should I handle that, do I resend a patch for net-next with the good
> >> subject prefix, and a v2 for -net?
> >
> > I applied this to net-next, thanks.
>
> Do we want to send this fix to -net as well?
Hi Vivien
I don't see this bug as being highly critical that it needs to be
fixed immediately.
I would suggest we wait until -rc1 is out, and then produce a backport
version. Given the changes we have made to that driver, there is
little chance the existing fix will cherry-pick backwards.
Andrew
next prev parent reply other threads:[~2016-05-17 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 0:38 [PATCH net] net: dsa: mv88e6xxx: remove bridge work Vivien Didelot
2016-05-14 1:28 ` Vivien Didelot
2016-05-16 17:48 ` David Miller
2016-05-17 15:39 ` Vivien Didelot
2016-05-17 16:03 ` Andrew Lunn [this message]
2016-05-17 16:23 ` Vivien Didelot
2016-05-17 16:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517160358.GC26948@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).