From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751492AbcERG31 (ORCPT ); Wed, 18 May 2016 02:29:27 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:35007 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbcERG30 (ORCPT ); Wed, 18 May 2016 02:29:26 -0400 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: ego@linux.vnet.ibm.com X-IBM-RcptTo: mpe@ellerman.id.au;linuxppc-dev@lists.ozlabs.org;mikey@neuling.org;linux-kernel@vger.kernel.org Date: Wed, 18 May 2016 11:59:18 +0530 From: Gautham R Shenoy To: "Shreyas B. Prabhu" Cc: mpe@ellerman.id.au, mikey@neuling.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/9] powerpc/powernv: Move idle code usable by multiple hardware to common location Message-ID: <20160518062917.GC3939@in.ibm.com> Reply-To: ego@linux.vnet.ibm.com References: <1462263878-25237-1-git-send-email-shreyas@linux.vnet.ibm.com> <1462263878-25237-4-git-send-email-shreyas@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462263878-25237-4-git-send-email-shreyas@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16051806-0005-0000-0000-000075389E83 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shreyas, On Tue, May 03, 2016 at 01:54:32PM +0530, Shreyas B. Prabhu wrote: > CPU-idle related code like context save/restore functions idle_power7.S > can reused for adding stop instruction support. Move this > code to a new commonly accessible location. [..snip..] > diff --git a/arch/powerpc/kernel/idle_power_common.S b/arch/powerpc/kernel/idle_power_common.S > new file mode 100644 > index 0000000..05954ae > --- /dev/null > +++ b/arch/powerpc/kernel/idle_power_common.S Since the new file is derived from idle_power7.S, you should add a comment here to indicate that this shares the copyright history with the original file. -- Thanks and Regards gautham.