From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbcERN1z (ORCPT ); Wed, 18 May 2016 09:27:55 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:47808 "EHLO e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbcERN1y (ORCPT ); Wed, 18 May 2016 09:27:54 -0400 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: cornelia.huck@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Wed, 18 May 2016 15:27:46 +0200 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Christian Borntraeger Subject: Re: [PATCH] virtio_balloon: fix PFN format for virtio-1 Message-ID: <20160518152746.1d6abdc2.cornelia.huck@de.ibm.com> In-Reply-To: <1463574848-15630-1-git-send-email-mst@redhat.com> References: <1463574848-15630-1-git-send-email-mst@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16051813-0041-0000-0000-000020181C54 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 May 2016 15:38:53 +0300 "Michael S. Tsirkin" wrote: > Everything should be LE when using virtio-1, but > the linux balloon driver does not seem to care about that. > > Cc: stable@vger.kernel.org > Reported-by: Cornelia Huck > Signed-off-by: Michael S. Tsirkin > --- > drivers/virtio/virtio_balloon.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) Keeping the pfns in proper byte order seems less hacky than my approach, and it fixes the crash for my setup as well. Tested-by: Cornelia Huck Reviewed-by: Cornelia Huck