From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753813AbcERSl6 (ORCPT ); Wed, 18 May 2016 14:41:58 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:38938 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753312AbcERSl4 (ORCPT ); Wed, 18 May 2016 14:41:56 -0400 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Wed, 18 May 2016 11:41:55 -0700 From: "Paul E. McKenney" To: Mark Rutland Cc: Arnd Bergmann , catalin.marinas@arm.com, dennis.chen@arm.com, jiangshanlai@gmail.com, josh@joshtriplett.org, linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, rostedt@goodmis.org, steve.capper@arm.com, will.deacon@arm.com Subject: Re: [PATCHv2] rcu: tree: correctly handle sparse possible CPUs Message-ID: <20160518184155.GB3528@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20160516191947.GH3528@linux.vnet.ibm.com> <20160517190106.GJ3528@linux.vnet.ibm.com> <20160518001251.GA13330@linux.vnet.ibm.com> <2685335.QWam4BCxRS@wuerfel> <20160518181509.GA8664@svinekod> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160518181509.GA8664@svinekod> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16051818-0013-0000-0000-000041CF644A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2016 at 07:15:09PM +0100, Mark Rutland wrote: > On Wed, May 18, 2016 at 02:02:36PM +0200, Arnd Bergmann wrote: > > It's the missing "possible_" that Mark mentioned in his reply on Friday. > > Actually, that was this morning. My VM on my laptop had a stale date due to > suspend/resume of the host. :/ > > I should be back at a real computer by Friday, and can respin the patch to fix > the issue Andrey pointed out. > > Thanks for the fixup, and sorry for the confusion! > > Mark. > > > Please fold the fixup below into the patch if you want to get it to build. > > > > Signed-off-by: Arnd Bergmann > diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h > > index fd6b0f701bed..bb137b0ef6f3 100644 > > --- a/kernel/rcu/tree_plugin.h > > +++ b/kernel/rcu/tree_plugin.h > > @@ -1165,7 +1165,7 @@ static void rcu_boost_kthread_setaffinity(struct rcu_node *rnp, int outgoingcpu) > > return; > > if (!zalloc_cpumask_var(&cm, GFP_KERNEL)) > > return; > > - for_each_leaf_node_cpu_bit(rnp, cpu, bit) > > + for_each_leaf_node_possible_cpu_bit(rnp, cpu, bit) > > if ((mask & bit) && cpu != outgoingcpu) > > cpumask_set_cpu(cpu, cm); > > if (cpumask_weight(cm) == 0) > > >