From: "'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>
To: 廖崇榮 <kt.liao@emc.com.tw>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
zac.hsieh@emc.com.tw, "'黃世鵬 經理'" <phoenix@emc.com.tw>,
"'Charles Mooney'" <charliemooney@google.com>,
"'Agnes Cheng'" <agnescheng@google.com>,
'jeff' <jeff.chuang@emc.com.tw>
Subject: Re: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger
Date: Thu, 19 May 2016 17:51:37 -0700 [thread overview]
Message-ID: <20160520005137.GA39923@dtor-ws> (raw)
In-Reply-To: <00c901d1b047$4a2d3ba0$de87b2e0$@emc.com.tw>
On Tue, May 17, 2016 at 10:20:40PM +0800, 廖崇榮 wrote:
> Hi Dmitry,
>
> I want to confirm my thought for your idea to avoid misunderstanding.
> I think you want to encapsulate " BTN_TOOL_FINGER" in the [input_mt_report_pointer_emulation] if hover happen.
> Vendor driver only report "ABS_DISTANCE" and let [input_mt_report_pointer_emulation] emit BTN_TOOL_FINGER report without change function parameter.
>
> Please let me know if my misunderstand about your idea.
Yes, that is correct. Something like this:
diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c
index 54fce56..a1bbec9 100644
--- a/drivers/input/input-mt.c
+++ b/drivers/input/input-mt.c
@@ -218,8 +218,23 @@ void input_mt_report_pointer_emulation(struct input_dev *dev, bool use_count)
}
input_event(dev, EV_KEY, BTN_TOUCH, count > 0);
- if (use_count)
+
+ if (use_count) {
+ if (count == 0 &&
+ !test_bit(ABS_MT_DISTANCE, dev->absbit) &&
+ test_bit(ABS_DISTANCE, dev->absbit) &&
+ input_abs_get_val(dev, ABS_DISTANCE) != 0) {
+ /*
+ * Force reporting BTN_TOOL_FINGER for devices that
+ * only report general hover (and not per-contact
+ * distance) when contact is in proximity but not
+ * on the surface.
+ */
+ count = 1;
+ }
+
input_mt_report_finger_count(dev, count);
+ }
if (oldest) {
int x = input_mt_get_value(oldest, ABS_MT_POSITION_X);
--
Dmitry
next prev parent reply other threads:[~2016-05-20 0:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 0:34 [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger duson
[not found] ` <006901d1acea$8207d090$861771b0$@emc.com.tw>
2016-05-16 11:27 ` 廖崇榮
2016-05-16 17:53 ` Dmitry Torokhov
2016-05-17 14:20 ` 廖崇榮
2016-05-20 0:51 ` 'Dmitry Torokhov' [this message]
2016-05-23 14:28 ` 廖崇榮
2016-05-26 0:11 ` 'Dmitry Torokhov'
2016-04-11 0:58 DusonLin
2016-04-19 5:18 DusonLin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520005137.GA39923@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=agnescheng@google.com \
--cc=charliemooney@google.com \
--cc=jeff.chuang@emc.com.tw \
--cc=kt.liao@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phoenix@emc.com.tw \
--cc=zac.hsieh@emc.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).