From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755603AbcETKZA (ORCPT ); Fri, 20 May 2016 06:25:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33032 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755409AbcETKY7 (ORCPT ); Fri, 20 May 2016 06:24:59 -0400 Date: Fri, 20 May 2016 12:24:56 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, peterz@infradead.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: Add top down metrics to perf stat Message-ID: <20160520102456.GC28818@krava> References: <1463190297-17408-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463190297-17408-1-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 20 May 2016 10:24:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 13, 2016 at 06:44:49PM -0700, Andi Kleen wrote: > Note to reviewers: includes both tools and kernel patches. > The kernel patches are at the beginning. > > [v2: Address review feedback. > Metrics are now always printed, but colored when crossing threshold. > --topdown implies --metric-only. > Various smaller fixes, see individual patches] > [v3: Add --single-thread option and support it with HT off. > Clean up old HT workaround. > Improve documentation. > Various smaller fixes, see individual patches.] > [v4: Rebased on latest tree] > [v5: Rebased on latest tree. Move debug messages to -vv] > [v6: Rebased. Remove .aggr-per-core and --single-thread to not > break old perf binaries. Put SMT enumeration into > generic topology API.] > [v7: Address review comments. Change patch title headers.] other than the missing headers and unnneeded initialization of have_frontend_stalled I'm ok with the perf tools part thanks, jirka