From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932617AbcETNjF (ORCPT ); Fri, 20 May 2016 09:39:05 -0400 Received: from mga03.intel.com ([134.134.136.65]:33891 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258AbcETNjE (ORCPT ); Fri, 20 May 2016 09:39:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,339,1459839600"; d="scan'208";a="706281969" Date: Fri, 20 May 2016 06:38:33 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, peterz@infradead.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] perf stat: Add computation of TopDown formulas Message-ID: <20160520133833.GU11177@tassilo.jf.intel.com> References: <1463190297-17408-1-git-send-email-andi@firstfloor.org> <1463190297-17408-9-git-send-email-andi@firstfloor.org> <20160520102327.GB28818@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160520102327.GB28818@krava> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > @@ -82,6 +87,12 @@ void perf_stat__reset_shadow_stats(void) > > sizeof(runtime_transaction_stats)); > > memset(runtime_elision_stats, 0, sizeof(runtime_elision_stats)); > > memset(&walltime_nsecs_stats, 0, sizeof(walltime_nsecs_stats)); > > + memset(runtime_topdown_total_slots, 0, sizeof(runtime_topdown_total_slots)); > > + memset(runtime_topdown_slots_retired, 0, sizeof(runtime_topdown_slots_retired)); > > + memset(runtime_topdown_slots_issued, 0, sizeof(runtime_topdown_slots_issued)); > > + memset(runtime_topdown_fetch_bubbles, 0, sizeof(runtime_topdown_fetch_bubbles)); > > + memset(runtime_topdown_recovery_bubbles, 0, sizeof(runtime_topdown_recovery_bubbles)); > > + have_frontend_stalled = pmu_have_event("cpu", "stalled-cycles-frontend"); > > why to initialize this one in here? it's already in perf_stat__init_shadow_stats You mean the have_frontend_stalled? I don't think it's in init_shadow_stats yet, but it could be moved. -Andi -- ak@linux.intel.com -- Speaking for myself only