linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>, Andi Kleen <andi@firstfloor.org>,
	acme@kernel.org, peterz@infradead.org, jolsa@kernel.org,
	mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] perf stat: Add computation of TopDown formulas
Date: Fri, 20 May 2016 07:15:38 -0700	[thread overview]
Message-ID: <20160520141538.GR13997@two.firstfloor.org> (raw)
In-Reply-To: <20160520134346.GA27581@krava>

On Fri, May 20, 2016 at 03:43:46PM +0200, Jiri Olsa wrote:
> On Fri, May 20, 2016 at 06:38:33AM -0700, Andi Kleen wrote:
> > > > @@ -82,6 +87,12 @@ void perf_stat__reset_shadow_stats(void)
> > > >  		sizeof(runtime_transaction_stats));
> > > >  	memset(runtime_elision_stats, 0, sizeof(runtime_elision_stats));
> > > >  	memset(&walltime_nsecs_stats, 0, sizeof(walltime_nsecs_stats));
> > > > +	memset(runtime_topdown_total_slots, 0, sizeof(runtime_topdown_total_slots));
> > > > +	memset(runtime_topdown_slots_retired, 0, sizeof(runtime_topdown_slots_retired));
> > > > +	memset(runtime_topdown_slots_issued, 0, sizeof(runtime_topdown_slots_issued));
> > > > +	memset(runtime_topdown_fetch_bubbles, 0, sizeof(runtime_topdown_fetch_bubbles));
> > > > +	memset(runtime_topdown_recovery_bubbles, 0, sizeof(runtime_topdown_recovery_bubbles));
> > > > +	have_frontend_stalled = pmu_have_event("cpu", "stalled-cycles-frontend");
> > > 
> > > why to initialize this one in here? it's already in perf_stat__init_shadow_stats
> > 
> > You mean the have_frontend_stalled?
> > 
> > I don't think it's in init_shadow_stats yet, but it could be moved.
> > 
> 
> fb4605ba47e7 perf stat: Check for frontend stalled for metrics
> 
> +void perf_stat__init_shadow_stats(void)
> +{
> +       have_frontend_stalled = pmu_have_event("cpu", "stalled-cycles-frontend");
> +}

Ok I removed the line and posted a new patch. Thanks.
-Andi

  reply	other threads:[~2016-05-20 14:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-14  1:44 Add top down metrics to perf stat Andi Kleen
2016-05-14  1:44 ` [PATCH 1/8] x86/topology: Add topology_max_smt_threads() Andi Kleen
2016-05-14  1:44 ` [PATCH 2/8] perf/x86: Support sysfs files depending on SMT status Andi Kleen
2016-05-14  1:44 ` [PATCH 3/8] perf/x86/intel: Add Top Down events to Intel Core Andi Kleen
2016-05-14  1:44 ` [PATCH 4/8] perf/x86/intel: Add Top Down events to Intel Atom Andi Kleen
2016-05-14  1:44 ` [PATCH 5/8] perf/x86/intel: Use new topology_max_smt_threads() in HT leak workaround Andi Kleen
2016-05-14  1:44 ` [PATCH 6/8] perf stat: Avoid fractional digits for integer scales Andi Kleen
2016-05-16 12:53   ` Jiri Olsa
2016-05-14  1:44 ` [PATCH 7/8] perf stat: Basic support for TopDown in perf stat Andi Kleen
2016-05-14  1:44 ` [PATCH 8/8] perf stat: Add computation of TopDown formulas Andi Kleen
2016-05-20 10:23   ` Jiri Olsa
2016-05-20 13:38     ` Andi Kleen
2016-05-20 13:43       ` Jiri Olsa
2016-05-20 14:15         ` Andi Kleen [this message]
2016-05-20 13:43     ` Andi Kleen
2016-05-16 12:58 ` Add top down metrics to perf stat Jiri Olsa
2016-05-19 23:51   ` Andi Kleen
2016-05-20  9:59     ` Jiri Olsa
2016-05-20 14:18       ` Andi Kleen
2016-05-20 10:24 ` Jiri Olsa
2016-05-20  0:09 Andi Kleen
2016-05-20  0:10 ` [PATCH 8/8] perf stat: Add computation of TopDown formulas Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160520141538.GR13997@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --subject='Re: [PATCH 8/8] perf stat: Add computation of TopDown formulas' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).