From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933258AbcETLDb (ORCPT ); Fri, 20 May 2016 07:03:31 -0400 Received: from mail.kernel.org ([198.145.29.136]:59130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933048AbcETLDa (ORCPT ); Fri, 20 May 2016 07:03:30 -0400 Date: Fri, 20 May 2016 20:03:13 +0900 From: Masami Hiramatsu To: Hemant Kumar Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar , Ananth N Mavinakayanahalli , Brendan Gregg Subject: Re: [PATCH perf/core v8 00/16] perf-probe --cache and SDT support Message-Id: <20160520200313.71872f94a2689efee02c7773@kernel.org> In-Reply-To: <573E97BD.20405@linux.vnet.ibm.com> References: <20160515031922.4017.13932.stgit@devbox> <573E97BD.20405@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 May 2016 10:21:09 +0530 Hemant Kumar wrote: > > > On 05/15/2016 08:49 AM, Masami Hiramatsu wrote: > > Hi, > > > > Here is the 8th version of the patchset for probe-cache and > > initial SDT support. > > > > The previous version is here; https://lkml.org/lkml/2016/5/11/446 > > > > This version I droped the second patch in v7 because it may > > involves unintended behavior change and we'd better discuss it > > out of this series. I also added comments why we can't use > > access(R_OK) for /proc/kcore. > > > > Hemant, could you review and test this series so that we can > > proceed to your patch depending on this? > > So, apart from the two issues which I mentioned in > the individual patches, it seems fine. Thanks! I'll fix those issues and send v9. > However, I think we will need a bit detailed documentation for the > probe cache feature as well as for the SDT support, given that we > have different commands to add {probe,sdt} events for a binary > and use them. I will write that that doc up based on your next > version. Would you mean updating Documentation/perf-probe.txt? Anyway it is welcome your contribution! Thank you, > > > > > Thank you, > > > > --- > > > > Hemant Kumar (1): > > perf/sdt: ELF support for SDT > > > > Masami Hiramatsu (15): > > perf buildid: Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE > > perf symbol: Cleanup the code flow of dso__find_kallsyms > > perf-buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid > > perf probe: Add --cache option to cache the probe definitions > > perf probe: Use cache entry if possible > > perf probe: Show all cached probes > > perf probe: Remove caches when --cache is given > > perf probe: Add group name support > > perf buildid-cache: Scan and import user SDT events to probe cache > > perf probe: Accept %sdt and %cached event name > > perf-list: Show SDT and pre-cached events > > perf-list: Skip SDTs placed in invalid binaries > > perf probe: Allow wildcard for cached events > > perf probe: Support @BUILDID or @FILE suffix for SDT events > > perf probe: Support a special SDT probe format > > > > > > tools/perf/Documentation/perf-probe.txt | 26 +- > > tools/perf/builtin-buildid-cache.c | 8 > > tools/perf/builtin-list.c | 4 > > tools/perf/builtin-probe.c | 30 ++ > > tools/perf/util/annotate.c | 2 > > tools/perf/util/build-id.c | 295 ++++++++++++++++-- > > tools/perf/util/build-id.h | 8 > > tools/perf/util/dso.h | 5 > > tools/perf/util/machine.c | 2 > > tools/perf/util/parse-events.c | 83 +++++ > > tools/perf/util/parse-events.h | 2 > > tools/perf/util/probe-event.c | 492 +++++++++++++++++++++++++++--- > > tools/perf/util/probe-event.h | 7 > > tools/perf/util/probe-file.c | 502 +++++++++++++++++++++++++++++++ > > tools/perf/util/probe-file.h | 41 +++ > > tools/perf/util/symbol-elf.c | 252 ++++++++++++++++ > > tools/perf/util/symbol.c | 73 ++--- > > tools/perf/util/symbol.h | 25 ++ > > 18 files changed, 1719 insertions(+), 138 deletions(-) > > > > -- > > Masami Hiramatsu > > > > -- > Thanks, > Hemant Kumar > -- Masami Hiramatsu