linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
	Tolga Cakir <cevelnet@gmail.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dell-smm-hwmon: Detect fan with index=2
Date: Sun, 22 May 2016 17:19:28 +0200	[thread overview]
Message-ID: <201605221719.28263@pali> (raw)
In-Reply-To: <5741CC16.1000909@roeck-us.net>

[-- Attachment #1: Type: Text/Plain, Size: 1456 bytes --]

On Sunday 22 May 2016 17:11:18 Guenter Roeck wrote:
> On 05/21/2016 05:31 PM, Pali Rohár wrote:
> > On Sunday 22 May 2016 02:21:46 Guenter Roeck wrote:
> >> On 05/21/2016 07:52 AM, Pali Rohár wrote:
> >>> Some Dell machines (e.g. Dell Precision M3800) have two fans,
> >>> first with index=0 and second with index=2. So export also
> >>> attributes for third fan device with index=2.
> >>> 
> >>> Reported-by: Tolga Cakir <cevelnet@gmail.com>
> >>> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> >>> ---
> >>> 
> >>>    drivers/hwmon/dell-smm-hwmon.c |   20 +++++++++++++++++++-
> >>>    1 file changed, 19 insertions(+), 1 deletion(-)
> >>> 
> >>> ---
> >>> 
> >>> Hi Tolga! Can you test this patch if sensors see fan device
> >>> correctly?
> >> 
> >> I assume this means I should wait for test results before applying
> >> the patch ?
> > 
> > Yes, testing should be done.
> > 
> > Do you have some pending/testing/next tree/branch for such patches?
> 
> I have a hwmon-staging branch. I added your patches to it.
> 
> Please use "hwmon: (dell-smm)" in the subject line of your patches.
> The subsystem name should come first, the driver name in () is a
> hwmon idiosyncrasy, and we don't need to repeat the "hwmon".

Ok, I use generic "driver_name: description" pattern as each subsystem 
use different format. But I can send in above format future hwmon 
patches...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2016-05-22 15:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-21 14:52 [PATCH] dell-smm-hwmon: Detect fan with index=2 Pali Rohár
2016-05-22  0:21 ` Guenter Roeck
2016-05-22  0:31   ` Pali Rohár
2016-05-22 15:11     ` Guenter Roeck
2016-05-22 15:19       ` Pali Rohár [this message]
2016-05-31 11:03 ` Pali Rohár
2016-06-01 11:34   ` Tolga Cakir
2016-06-13 18:26     ` Pali Rohár
2016-06-14  2:01       ` Guenter Roeck
2016-06-15  8:02         ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201605221719.28263@pali \
    --to=pali.rohar@gmail.com \
    --cc=cevelnet@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).