From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932396AbcEWMeE (ORCPT ); Mon, 23 May 2016 08:34:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36927 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752068AbcEWMeC (ORCPT ); Mon, 23 May 2016 08:34:02 -0400 Date: Mon, 23 May 2016 07:33:59 -0500 From: Josh Poimboeuf To: Matt Fleming Cc: Linus Torvalds , Ingo Molnar , Alex Thorlton , Linux Kernel Mailing List , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , Peter Zijlstra , Borislav Petkov Subject: Re: [GIT PULL] EFI fix Message-ID: <20160523123359.5ykm7hiwvkgyc77v@treble> References: <20160516144648.GA22999@gmail.com> <20160523120801.GB2984@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160523120801.GB2984@codeblueprint.co.uk> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 23 May 2016 12:34:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2016 at 01:08:01PM +0100, Matt Fleming wrote: > On Mon, 16 May, at 01:05:45PM, Linus Torvalds wrote: > > > > I think the right fix is to just get rid of that silly conditional > > frame pointer thing, and always use frame pointers in this stub > > function. And then we don't need that (odd) load to get the old stack > > pointer into %rax - we can just use the frame pointer. > > > > Something like the attached completely untested patch. > > Linus, are you going to apply your patch directly or would you prefer > someone to send a pull request which also includes Josh's patch for > arch/x86/entry/thunk_64.S? Ingo already merged both patches into tip:x86/urgent, so I'd presume he'll be sending a pull request for them soon. -- Josh