From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754583AbcEWNJ0 (ORCPT ); Mon, 23 May 2016 09:09:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60565 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753157AbcEWNJY (ORCPT ); Mon, 23 May 2016 09:09:24 -0400 Date: Mon, 23 May 2016 15:09:18 +0200 From: Jesper Dangaard Brouer To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Jason Wang , Eric Dumazet , davem@davemloft.net, netdev@vger.kernel.org, Steven Rostedt , brouer@redhat.com Subject: Re: [PATCH v5 2/2] skb_array: ring test Message-ID: <20160523150918.2c58fa7d@redhat.com> In-Reply-To: <1464000201-15560-3-git-send-email-mst@redhat.com> References: <1464000201-15560-1-git-send-email-mst@redhat.com> <1464000201-15560-3-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 23 May 2016 13:09:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 May 2016 13:43:46 +0300 "Michael S. Tsirkin" wrote: > Add ringtest based unit test for skb array. > > Signed-off-by: Michael S. Tsirkin > --- > tools/virtio/ringtest/skb_array.c | 167 ++++++++++++++++++++++++++++++++++++++ > tools/virtio/ringtest/Makefile | 4 +- Patch didn't apply cleanly to Makefile, as you also seems to have "virtio_ring_inorder", I manually applied it. I chdir to tools/virtio/ringtest/ and I could compile "skb_array", BUT how do I use it??? (the README is not helpful) What is the "output", are there any performance measurement results? > diff --git a/tools/virtio/ringtest/Makefile b/tools/virtio/ringtest/Makefile > index 6ba7455..87e58cf 100644 > --- a/tools/virtio/ringtest/Makefile > +++ b/tools/virtio/ringtest/Makefile > @@ -1,6 +1,6 @@ > all: > > -all: ring virtio_ring_0_9 virtio_ring_poll virtio_ring_inorder > +all: ring virtio_ring_0_9 virtio_ring_poll virtio_ring_inorder skb_array ^^^^^^^^^^^^^^^^^^^ > > CFLAGS += -Wall > CFLAGS += -pthread -O2 -ggdb > @@ -8,6 +8,7 @@ LDFLAGS += -pthread -O2 -ggdb > > main.o: main.c main.h > ring.o: ring.c main.h > +skb_array.o: skb_array.c main.h ../../../include/linux/skb_array.h > virtio_ring_0_9.o: virtio_ring_0_9.c main.h > virtio_ring_poll.o: virtio_ring_poll.c virtio_ring_0_9.c main.h > virtio_ring_inorder.o: virtio_ring_inorder.c virtio_ring_0_9.c main.h > @@ -15,6 +16,7 @@ ring: ring.o main.o > virtio_ring_0_9: virtio_ring_0_9.o main.o > virtio_ring_poll: virtio_ring_poll.o main.o > virtio_ring_inorder: virtio_ring_inorder.o main.o ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ > +skb_array: skb_array.o main.o > clean: > -rm main.o > -rm ring.o ring -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer