From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753203AbcEWQ6B (ORCPT ); Mon, 23 May 2016 12:58:01 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59488 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021AbcEWQ57 (ORCPT ); Mon, 23 May 2016 12:57:59 -0400 Date: Mon, 23 May 2016 17:57:13 +0100 From: Mark Brown To: Jose Abreu Cc: alsa-devel@alsa-project.org, Carlos Palminha , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Alexey Brodkin , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20160523165713.GX8206@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4PR/+zdSfVlxyWed" Content-Disposition: inline In-Reply-To: X-Cookie: Vitamin C deficiency is apauling. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/4 v7] ASoC: dwc: Do not use devm_clk_get() if using platform data X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4PR/+zdSfVlxyWed Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 23, 2016 at 11:02:23AM +0100, Jose Abreu wrote: > When using platform data the devm_clk_get() function is > called causing a probe failure if the clock is not > declared. As we can pass the clock handler by platform > data call only devm_clk_get() when platform data is not > used. No, this is broken - if the device needs a clock the device needs a clock and clock names should be static rather than passed in via platform data (indeed NULL is a perfectly valid clock name). The system integation should map in a clock as needed, if it's just a fixed crystal or something then just register a fixed clock and connect it up. --4PR/+zdSfVlxyWed Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXQzZoAAoJECTWi3JdVIfQR8kH/06w5PKPgXydQmaUoZe827Zr TZxCfzV3r2AffBSDGIK5rXscDBzd6obkbc8+FHgC7MqZpEjtHBLRCiy+ukFdrsZ2 Ue+c5dLvVpx46OfXqmBfRMhOxBqSY5JfE9rYBkrZo5M3Q+cwe4BLJU9ErubfU34s vG6JlFXH9vQmsUahC4F6kL+Sffhazmzt4dBsWzasgcohBbuyQ4dGCLNdwG8BTobz qkRVx2K1YaaKz0zoKK0X3MrW6ETvtnUuuNeVz5vdhGahOG/eZHvFqv4GaLycTvVd 9mDQV8pZzvConI0GWOBvNjzF2hQgXBgM1Gj10P9xeBAH7fpY1aJOCoZGlj9diX4= =1xV8 -----END PGP SIGNATURE----- --4PR/+zdSfVlxyWed--