From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752408AbcEWVGY (ORCPT ); Mon, 23 May 2016 17:06:24 -0400 Received: from 216-12-86-13.cv.mvl.ntelos.net ([216.12.86.13]:58274 "EHLO brightrain.aerifal.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062AbcEWVGW (ORCPT ); Mon, 23 May 2016 17:06:22 -0400 Date: Mon, 23 May 2016 17:06:18 -0400 From: Rich Felker To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Ian Campbell , Kumar Gala , Mark Rutland , Pawel Moll Subject: Re: [PATCH v2 05/12] of: add J-Core SPI master bindings Message-ID: <20160523210618.GF21636@brightrain.aerifal.cx> References: <32585cfb27d31e9d5cb399ecc4d8b89f4ec5e2cb.1463708766.git.dalias@libc.org> <20160523210020.GA23118@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160523210020.GA23118@rob-hp-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2016 at 04:00:20PM -0500, Rob Herring wrote: > On Fri, May 20, 2016 at 02:53:04AM +0000, Rich Felker wrote: > > Signed-off-by: Rich Felker > > --- > > .../devicetree/bindings/spi/jcore,spi.txt | 23 ++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/spi/jcore,spi.txt > > > > diff --git a/Documentation/devicetree/bindings/spi/jcore,spi.txt b/Documentation/devicetree/bindings/spi/jcore,spi.txt > > new file mode 100644 > > index 0000000..9055e7d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/spi/jcore,spi.txt > > @@ -0,0 +1,23 @@ > > +J-Core SPI master > > + > > +Required properties: > > + > > +- compatible: Must be "jcore,spi2". > > In general, these all seem a bit generic. You should be able to > correlate IP versions to compatible strings. "spi2" is the name of the "IP core" in the J-Core source tree. The WIP that adds DMA support and makes some changes is called "spi3" there; I'll submit a patch adding "jcore,spi3" to the binding file once the vhdl for it has been released. Rich