From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754844AbcEXJEN (ORCPT ); Tue, 24 May 2016 05:04:13 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:32994 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753720AbcEXJEK (ORCPT ); Tue, 24 May 2016 05:04:10 -0400 Date: Tue, 24 May 2016 11:03:26 +0200 From: Ingo Molnar To: Josh Poimboeuf Cc: Matt Fleming , Linus Torvalds , Alex Thorlton , Linux Kernel Mailing List , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , Peter Zijlstra , Borislav Petkov Subject: Re: [GIT PULL] EFI fix Message-ID: <20160524090326.GA20176@gmail.com> References: <20160516144648.GA22999@gmail.com> <20160523120801.GB2984@codeblueprint.co.uk> <20160523123359.5ykm7hiwvkgyc77v@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160523123359.5ykm7hiwvkgyc77v@treble> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Josh Poimboeuf wrote: > On Mon, May 23, 2016 at 01:08:01PM +0100, Matt Fleming wrote: > > On Mon, 16 May, at 01:05:45PM, Linus Torvalds wrote: > > > > > > I think the right fix is to just get rid of that silly conditional > > > frame pointer thing, and always use frame pointers in this stub > > > function. And then we don't need that (odd) load to get the old stack > > > pointer into %rax - we can just use the frame pointer. > > > > > > Something like the attached completely untested patch. > > > > Linus, are you going to apply your patch directly or would you prefer > > someone to send a pull request which also includes Josh's patch for > > arch/x86/entry/thunk_64.S? > > Ingo already merged both patches into tip:x86/urgent, so I'd presume > he'll be sending a pull request for them soon. Correct, I plan to send them later today. Thanks, Ingo