From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754420AbcEYJvq (ORCPT ); Wed, 25 May 2016 05:51:46 -0400 Received: from smtp2.macqel.be ([109.135.2.61]:59416 "EHLO smtp2.macqel.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753174AbcEYJvo (ORCPT ); Wed, 25 May 2016 05:51:44 -0400 Date: Wed, 25 May 2016 11:51:39 +0200 From: Philippe De Muyter To: George Spelvin Cc: geert@linux-m68k.org, gerg@linux-m68k.org, linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org Subject: Re: [PATCH 08/10] m68k: Add Message-ID: <20160525095139.GA19910@frolo.macqel> References: <20160525085653.GA9917@frolo.macqel> <20160525091435.9218.qmail@ns.sciencehorizons.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160525091435.9218.qmail@ns.sciencehorizons.net> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 25, 2016 at 05:14:35AM -0400, George Spelvin wrote: > > I did it the way I did above because it makes the gcc -S output very > legible. Just like I put a space before the perands on m68k but a tab > on h8300: that's what GCC does on those platforms. > > I started with the "\n\t" suffixes on each line like so much other > kernel code, but then figured out the format above which is legible > both in C source and compiler output. OK thanks. > > >> asm("move.l %2,%0;" /* 0x0001 */ > >> "lsl.l #2,%0;" /* 0x0004 */ > >> "move.l %0,%1;" > >> "lsl.l #7,%0;" /* 0x0200 */ > >> "add.l %2,%0;" /* 0x0201 */ > >> "add.l %0,%1;" /* 0x0205 */ > >> "add.l %0,%0;" /* 0x0402 */ > >> "add.l %0,%1;" /* 0x0607 */ > >> "lsl.l #5,%0" /* 0x8040 */ > >> /* 0x8647 */ > > > Also, it took me some time to understand the hexadecimal constants > > in the comments (and the last one predicts a future event :)). > > > Can you recmmend a better way to comment this? My nose is so deep > in the code it's hard for me to judge. I second Andreas' suggestion. Philippe -- Philippe De Muyter +32 2 6101532 Macq SA rue de l'Aeronef 2 B-1140 Bruxelles