From: Yury Norov <ynorov@caviumnetworks.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: <arnd@arndb.de>, <catalin.marinas@arm.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-arch@vger.kernel.org>, <linux-s390@vger.kernel.org>,
<libc-alpha@sourceware.org>, <nd@arm.com>,
<schwidefsky@de.ibm.com>, <heiko.carstens@de.ibm.com>,
<pinskia@gmail.com>, <broonie@kernel.org>,
<joseph@codesourcery.com>,
<christoph.muellner@theobroma-systems.com>,
<bamvor.zhangjian@huawei.com>, <klimov.linux@gmail.com>,
<Nathan_Lynch@mentor.com>, <agraf@suse.de>,
<Prasun.Kapoor@caviumnetworks.com>, <kilobyte@angband.pl>,
<geert@linux-m68k.org>, <philipp.tomsich@theobroma-systems.com>
Subject: Re: [PATCH v6 00/21] ILP32 for ARM64
Date: Wed, 25 May 2016 19:41:32 +0300 [thread overview]
Message-ID: <20160525164132.GB4595@yury-N73SV> (raw)
In-Reply-To: <5745817C.1070406@arm.com>
On Wed, May 25, 2016 at 11:42:04AM +0100, Szabolcs Nagy wrote:
> On 24/05/16 01:04, Yury Norov wrote:
> > This version is based on kernel v4.6.
> > It works with glibc-2.23, and tested with LTP.
> >
> ...
> > ILP32 glibc branch is available here:
> > https://github.com/norov/glibc/tree/ilp32-2.23
> >
> > It is tested with this series with no major downsides. I will send it to
> > glibc-alpha soon, after final revise. Please review and comment it as well.
>
> i spotted one __ilp32__ vs __ILP32__ typo in the glibc code,
Yes, I also found it. Thank you.
> i can review it in detail when there is a cleaned up patch set.
>
> in general the approach seems ok, the ugly part is when lp64
> and ilp32 share code, but ilp32 needs some tweaks compared to
> the current code (e.g. x vs w regs in asm, long changed to
> long long in syscalls, different relocations etc) those will
> be hard to review. the naming is sometimes _be_ilp32 sometimes
> ilp32_be, but let's hope there will be no new abi variant to
> confuse this further.
I think I shared the link too soon, and patches should be revised
again. So I continue the work on it. If you curious, find it here.
https://github.com/norov/glibc/tree/ilp32-dev
(I don't promise I'll keep it stable, or will avoid using things like
fast-forward. It's just a branch for my experiments.)
For now, it has fixed:
- __ilp32__ mess (by introducing DELOUSE() macro);
- few unneeded patches dropped;
- 32-bit off_t turned to 64-bit.
With all changes, LPT fail list grows:
peio_3 FAIL 5
pipeio_6 FAIL 1
abort01 FAIL 2
clone02 FAIL 4
fcntl11 FAIL 1
fcntl14 FAIL 1
fcntl17 FAIL 1
fcntl19 FAIL 1
fcntl20 FAIL 1
fcntl21 FAIL 1
fpathconf01 FAIL 1
ftruncate04 FAIL 1
kill11 FAIL 2
mmap16 FAIL 6
open12 FAIL 2
pread01 FAIL 2
pread02 FAIL 2
pread03 FAIL 2
preadv01 FAIL 6
preadv02 FAIL 6
pwrite01 FAIL 2
pwrite02 FAIL 2
pwrite04 FAIL 6
pwrite02_64 FAIL 1
pwritev01 FAIL 2
pwritev02 FAIL 2
rename11 FAIL 2
rmdir02 FAIL 2
umount2_01 FAIL 2
umount2_02 FAIL 2
umount2_03 FAIL 2
utime06 FAIL 2
mtest01 FAIL 1
mtest01w FAIL 1
mtest06 FAIL 11
gf01 FAIL 1
gf02 FAIL 1
gf07 FAIL 1
gf10 FAIL 1
gf11 FAIL 1
gf15 FAIL 1
gf18 FAIL 1
gf19 FAIL 1
Yury
next prev parent reply other threads:[~2016-05-25 16:41 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 0:04 [PATCH v6 00/21] ILP32 for ARM64 Yury Norov
2016-05-24 0:04 ` [PATCH 01/23] all: syscall wrappers: add documentation Yury Norov
2016-05-25 19:30 ` David Miller
2016-05-25 20:03 ` Yury Norov
2016-05-25 20:21 ` David Miller
2016-05-25 20:47 ` Arnd Bergmann
2016-05-25 20:50 ` David Miller
2016-05-25 21:01 ` Arnd Bergmann
2016-05-25 21:28 ` David Miller
2016-05-26 14:20 ` Catalin Marinas
2016-05-26 14:50 ` Szabolcs Nagy
2016-05-26 15:19 ` Catalin Marinas
2016-05-26 19:43 ` David Miller
2016-05-27 10:10 ` Catalin Marinas
2016-05-26 20:48 ` Yury Norov
2016-05-26 22:29 ` Catalin Marinas
2016-05-27 0:37 ` Yury Norov
2016-05-27 6:03 ` Heiko Carstens
2016-05-27 8:42 ` Arnd Bergmann
2016-05-27 9:30 ` Catalin Marinas
2016-05-27 10:49 ` Arnd Bergmann
2016-05-27 13:04 ` Catalin Marinas
2016-05-27 16:58 ` Yury Norov
2016-05-27 17:36 ` Catalin Marinas
2016-05-27 9:01 ` Catalin Marinas
2016-06-14 23:08 ` Yury Norov
2016-05-27 5:52 ` Heiko Carstens
2016-05-24 0:04 ` [PATCH 02/23] all: introduce COMPAT_WRAPPER option and enable it for s390 Yury Norov
2016-05-24 0:04 ` [PATCH 03/23] all: s390: move wrapper infrastructure to generic headers Yury Norov
2016-05-24 0:04 ` [PATCH 04/23] all: s390: move compat_wrappers.c from arch/s390/kernel to kernel/ Yury Norov
2016-05-24 0:04 ` [PATCH 05/23] all: wrap needed syscalls in generic unistd Yury Norov
2016-05-24 0:04 ` [PATCH 06/23] compat ABI: use non-compat openat and open_by_handle_at variants Yury Norov
2016-05-24 0:04 ` [PATCH 07/23] 32-bit ABI: introduce ARCH_32BIT_OFF_T config option Yury Norov
2016-05-24 0:04 ` [PATCH 08/23] arm64: ilp32: add documentation on the ILP32 ABI for ARM64 Yury Norov
2016-05-24 0:04 ` [PATCH 09/23] arm64: ensure the kernel is compiled for LP64 Yury Norov
2016-05-24 0:04 ` [PATCH 10/23] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov
2016-05-24 0:04 ` [PATCH 11/23] arm64:uapi: set __BITS_PER_LONG correctly for ILP32 and LP64 Yury Norov
2016-05-24 0:04 ` [PATCH 12/23] thread: move thread bits accessors to separated file Yury Norov
2016-05-24 0:04 ` [PATCH 13/23] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Yury Norov
2016-06-12 12:21 ` Zhangjian (Bamvor)
2016-06-12 13:08 ` Zhangjian (Bamvor)
2016-06-12 17:56 ` Yury Norov
2016-05-24 0:04 ` [PATCH 14/23] arm64: ilp32: add is_ilp32_compat_{task,thread} and TIF_32BIT_AARCH64 Yury Norov
2016-05-24 0:04 ` [PATCH 15/23] arm64: introduce binfmt_elf32.c Yury Norov
2016-05-24 0:04 ` [PATCH 16/23] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov
2016-05-26 13:49 ` Zhangjian (Bamvor)
2016-05-26 21:08 ` Yury Norov
2016-06-15 0:40 ` Yury Norov
2016-06-13 3:05 ` Zhangjian (Bamvor)
2016-06-13 13:22 ` Zhangjian (Bamvor)
2016-05-24 0:04 ` [PATCH 17/23] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32 Yury Norov
2016-06-08 1:34 ` zhouchengming
2016-06-08 17:00 ` Yury Norov
2016-06-25 9:36 ` zhouchengming
2016-06-25 14:15 ` Bamvor Zhang
2016-06-27 2:09 ` zhouchengming
2016-05-24 0:04 ` [PATCH 18/23] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov
2016-05-25 20:26 ` Arnd Bergmann
2016-05-24 0:04 ` [PATCH 19/23] arm64: signal: share lp64 signal routines to ilp32 Yury Norov
2016-05-24 0:04 ` [PATCH 20/23] arm64: signal32: move ilp32 and aarch32 common code to separated file Yury Norov
2016-05-24 0:04 ` [PATCH 21/23] arm64: ilp32: introduce ilp32-specific handlers for sigframe and ucontext Yury Norov
2016-06-04 11:34 ` Zhangjian (Bamvor)
2016-06-12 12:34 ` Zhangjian (Bamvor)
2016-06-12 13:12 ` Zhangjian (Bamvor)
2016-06-12 17:44 ` Yury Norov
2016-06-16 11:21 ` Zhangjian (Bamvor)
2016-06-12 12:39 ` Zhangjian (Bamvor)
2016-05-24 0:04 ` [PATCH 22/23] arm64:ilp32: add vdso-ilp32 and use for signal return Yury Norov
2016-05-24 0:04 ` [PATCH 23/23] arm64:ilp32: add ARM64_ILP32 to Kconfig Yury Norov
2016-05-25 10:42 ` [PATCH v6 00/21] ILP32 for ARM64 Szabolcs Nagy
2016-05-25 16:41 ` Yury Norov [this message]
2016-06-02 19:03 ` Yury Norov
2016-06-03 11:02 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525164132.GB4595@yury-N73SV \
--to=ynorov@caviumnetworks.com \
--cc=Nathan_Lynch@mentor.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bamvor.zhangjian@huawei.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=joseph@codesourcery.com \
--cc=kilobyte@angband.pl \
--cc=klimov.linux@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nd@arm.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=pinskia@gmail.com \
--cc=schwidefsky@de.ibm.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).