From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932299AbcEYRMV (ORCPT ); Wed, 25 May 2016 13:12:21 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:46470 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932085AbcEYRMT (ORCPT ); Wed, 25 May 2016 13:12:19 -0400 Authentication-Results: infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=none action=none header.from=fb.com; Date: Wed, 25 May 2016 13:11:31 -0400 From: Chris Mason To: Peter Zijlstra CC: , , , , , Subject: Re: [RFC][PATCH 0/7] sched: select_idle_siblings rewrite Message-ID: <20160525171131.GA67858@clm-mbp.thefacebook.com> Mail-Followup-To: Chris Mason , Peter Zijlstra , mingo@kernel.org, linux-kernel@vger.kernel.org, matt@codeblueprint.co.uk, mgalbraith@suse.de, tglx@linutronix.de, fweisbec@gmail.com References: <20160509104807.284575300@infradead.org> <20160525145120.zw4wxb3auiwiq3tm@floor.thefacebook.com> <20160525162449.GW3193@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Disposition: inline In-Reply-To: <20160525162449.GW3193@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [2620:10d:c091:180::3e2f] X-ClientProxiedBy: SN1PR0701CA0043.namprd07.prod.outlook.com (10.163.126.11) To CY1PR15MB0875.namprd15.prod.outlook.com (10.169.22.141) X-MS-Office365-Filtering-Correlation-Id: 2f4a3cc5-3065-407d-cec4-08d384bfa353 X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0875;2:criI4vT3wrqqv2JZUn3UP75rOu8LqciXgB7Kj8eHQUOtPFHzhf3jn1NIVuqoA/g0RFis7RdkobO7QlQGHWKutAGFK4sVJeKBAyzGKBcqsaHHaOLg1ubuWziNwLDhS1hl5Ys9skBdWEVLxdv4yskmCbfDyjW60BmNlvw0LxtLULh1iaK8yVVq+5LXAQ0a6eY1;3:TserCwLApXxPrg+Y+f0tjlwWu4jp3FM0cd4tJSTxUTCNccPGwdMjkuDmwqm5yfHIoz4luySAImd+q/pdkxe4MWUhPZBYuVt8/fGCnRgsa1Hnaxf6By9MYI+EgLrQHt92;25:TZvIHihzwWUkbAVLvPwLfgh9T1uMg10fNI9/+0v4Sa0OYUpL3eZOlpSbl8bG58vqSD3+HCL5GnxT+THSINuZEq1sFom/e7TXxuQorzZDQ3AM28jVIADDqxuXA/8QUefJkhqRZsMxri9Dxh/UOUianERQyBUOSPlNVOQoG95Y9y5I+RSOpK+HFz34HME6u5YyWSVtET6BoiSXLo4ywv8JZxvMOxuz1cLOUwEk0+HKBMpB5PEMLDmvqY5ltsdMoGeBlYMI1vzJafHyF4m17GGrSzqMIC8ITDv2PdiLkXPr70TNzv8h5imsw+EKJieMHFwZ3EoLQ7Z+OpyDiVehHlpz0t6ofp0FcWL6Ji6r/i90dYIl0OTEK1CYXQQ4u25ngW5Qx+OpO+cTY2lYKZtTVLJ556Qf1w5qME+wnqS9PejT2J8=;20:3xzB5IuLSn1v+a1KbdIvt/N96Oc6P+uI6AlPqajdlnQbq/8fPWGGRsI+Hfl5mXq+7SkPU7RQRTpXfH5QIDZE4SGkuDxp1bUXDn522Ru96n9D8HljeSFDLIsAOmTl1iM0fc5+Nw+GsjkPlWkxq3SqRl/F2ur1qj7FV1373Z3LmTs= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR15MB0875; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY1PR15MB0875;BCL:0;PCL:0;RULEID:;SRVR:CY1PR15MB0875; X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0875;4:4XRpQJliDPCfy8TEpJwRiIK0CAUiONAGCSJ+WzO/WJWHaQPdHiyOaS4C/FfR+kPvg6ahulu0C/mxJaFNO+WH/VcX2ADXK7Lj9qk8xxcOGHRGCG0E8Y9o+jpdFWSnTBjdA4GarSKNA/lg415smNbhrcDdvVG1pteU2vSxfpneM89wJnlfcyx6JmPfHdA61h2/7qdwxmmR/8orwHNb57dMVspk0uLnzVZnIegLyKVe5woHRUwqJhc1yZoyhrdEYCbJ7F76tZ8venN/VrlRuIvfwd0GdfKOppZcZj9hXI+LLSEmJDyJo+K3SbZ8dz1x0ELMUly1ppKegiSdtn40QEUDko/5xN1hCVsEbNmtY0zHyM0ohj3z914XYzvW44GtXVQT X-Forefront-PRVS: 09538D3531 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(979002)(6009001)(24454002)(2906002)(50986999)(92566002)(83506001)(76176999)(54356999)(6116002)(23726003)(4326007)(586003)(5008740100001)(42186005)(77096005)(1076002)(2950100001)(81166006)(8676002)(50466002)(33656002)(47776003)(53416004)(110136002)(9686002)(86362001)(5004730100002)(189998001)(4001350100001)(3826002)(42262002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR15MB0875;H:clm-mbp.thefacebook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR15MB0875;23:ZFq5ZBZLG0k0uLH8JEjHzR2+kS3uAOByj2iYmDd1v?= =?us-ascii?Q?icHmLR0yhISbB7JaE8hmzcLMjVw0bo/5EWM2T04Af2OUPau6Mr0EfjY8T9zG?= =?us-ascii?Q?Ej7Ypi4919j6x6wFF3skFUx/71pskuoM0Y8UobCe4mGlH+N9VjcCUs2sdHV+?= =?us-ascii?Q?hQRLZ/7sTlDgsFaBQiM42uJXNi3uNUGzj2KYMyElSBk/KP7Bvj2cMTCcjm2J?= =?us-ascii?Q?a3PJqeuzfgKBexQhAXUY3RFtjJhSM1CGTYkrs4c2YO0EPh1tcA4ARWj+Ycy/?= =?us-ascii?Q?9B65G9XkF1w1rOaJGmn5N3WGzDZDBwVBS8e8yx3jm0NfLAx1OMBNYlpLcGYl?= =?us-ascii?Q?HDqpUm4/76YKm7+O3eVNCni/fLtIbp/aBJlollLEj1vYrWexYSzw64VMtyRS?= =?us-ascii?Q?qx25DVEralsvGiJvR52wsemtNjfkkQ8XldzaFO34ARmyWWpzoJROwlCFyt/v?= =?us-ascii?Q?hJ+kymGxPRLSQVV+dj1Zg3OgV4W3cBvQWP8aqOhETpOsLoaaBPRFsI/t+sro?= =?us-ascii?Q?JY2CQrU4Sn77TwdLMdv63YWE+7ZzGZR3eNGO/Iglc22sKH9SeJG+wMQdv+AF?= =?us-ascii?Q?29EsBpOmHKrR/7XvXcTXStgaieMhUGwxEv3bUFn3lFCq1vRV1rnocppqkvNX?= =?us-ascii?Q?VnyinI/taicz/PLzCX041tJXX4VkjmTuNApH3354+s+SpPNv9Zgtf3e8L3ek?= =?us-ascii?Q?4VtUqRcyBTNUyVExfrzERWzlOyxh/GEt35RngBfEN8t2ugzH4olgv0wFbA4u?= =?us-ascii?Q?/9LQWorh4cdQJWIQNZiAFa4Z8YrzIiZhRgwra2rhxiIYt1hlTB31gxT93H2H?= =?us-ascii?Q?Su8+fpRqPAR/1y+ViuPKjYm95GdlXpdfRbmgICbTIdjaC/7qOF3jFaltLOID?= =?us-ascii?Q?HPrhoTBQAFFlC8cw0W8aJJg4K5ey640RrSAKYIMgLQQQwTNPQ8ZoBUKDwoav?= =?us-ascii?Q?HVsFbAuA7edsCZGHJxm7KHxh0w2sVkEJhGuxh0Hqw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0875;5:nvhXUt1ecruVdTzqs8/8ckFv0XK2Mc9PHoYjE97BUK3uRkuPK9q8cPWFuShPngTq/5f9I7uaoJ6lzPNC3yMTdO1BzqMJzEfcmTdHt2gSXUW/QqF0xLGmgOu2E8geUZi8gXshAWnLb3Et9naPu+jvIA==;24:WbhbkdB+LYSdFp9AvvsmJxWbQfRC2799kU56KsOcFFKthJ0WfumHMlN4mN7YQYF2I8+n691IeyEz5EFx/c12rUUqh3MNozcVs6Lsb6Yd2BA=;7:SpgkdO5WtxnUcA9uEWCHGjhu1L1zS/SVxZNx+Ghgb7CJBHvzyQ7c9jNJYxr6uYiIeXabj8pF2vDxsh9w7pZaUutxAmdAVjlowerq16nKi0hPWvgfAt4wRQZ7THucEPFcftzjjfU3DQigqUgZ/mf0GWWwuihfYky5xbJ4wlYqr54golloBgoet1AtUTiZeSit;20:q3sacWGiDjlYJBtiojL8kOyzaBwLIbIOwZrXfphc91IEFC7HbdjYoNFshpaA+kjDRwit0f+c/cwKMSBKgW2gHGAzhCBtNocJ8ihud7p6W/nBZtM8l8TZKxm6EhIuCUnMOWLzd9xq/C+ag+GNr7doJYVZgCk5jIuoCnnreYLQK58= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2016 17:11:39.2388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR15MB0875 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-05-25_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 25, 2016 at 06:24:49PM +0200, Peter Zijlstra wrote: >On Wed, May 25, 2016 at 10:51:20AM -0400, Chris Mason wrote: >> On Mon, May 09, 2016 at 12:48:07PM +0200, Peter Zijlstra wrote: >> > Hai, >> > >> > here be a semi coherent patch series for the recent select_idle_siblings() >> > tinkering. Happy benchmarking.. >> >> This took a while, mostly because my original schbench showed your >> patches were just as fast as our internal patch, but our production >> benchmark showed a 5-10% regression. My theory was just that schbench >> wasn't fine grained enough, and the load would stop before the >> regression kicked in. > >Just to be sure; regression as per your production kernel, not vs. >mainline, right? Sorry yes, that's correct. -chris