From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754197AbcEZO4M (ORCPT ); Thu, 26 May 2016 10:56:12 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33238 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753925AbcEZO4K (ORCPT ); Thu, 26 May 2016 10:56:10 -0400 Date: Thu, 26 May 2016 16:56:08 +0200 From: Michal Hocko To: Tetsuo Handa Cc: linux-mm@kvack.org, rientjes@google.com, oleg@redhat.com, vdavydov@parallels.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] mm, oom: fortify task_will_free_mem Message-ID: <20160526145608.GE23675@dhcp22.suse.cz> References: <1464266415-15558-1-git-send-email-mhocko@kernel.org> <1464266415-15558-7-git-send-email-mhocko@kernel.org> <201605262311.FFF64092.FFQVtOLOOMJSFH@I-love.SAKURA.ne.jp> <20160526142317.GC23675@dhcp22.suse.cz> <201605262341.GFE48463.OOtLFFMQSVFHOJ@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201605262341.GFE48463.OOtLFFMQSVFHOJ@I-love.SAKURA.ne.jp> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 26-05-16 23:41:54, Tetsuo Handa wrote: > Michal Hocko wrote: > > +/* > > + * Checks whether the given task is dying or exiting and likely to > > + * release its address space. This means that all threads and processes > > + * sharing the same mm have to be killed or exiting. > > + */ > > +static inline bool task_will_free_mem(struct task_struct *task) > > +{ > > + struct mm_struct *mm = NULL; > > + struct task_struct *p; > > + bool ret = false; > > If atomic_read(&p->mm->mm_users) <= get_nr_threads(p), this returns "false". > According to previous version, I think this is "bool ret = true;". true. Thanks for catching this. Fixed locally. -- Michal Hocko SUSE Labs