From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755374AbcEZVI0 (ORCPT ); Thu, 26 May 2016 17:08:26 -0400 Received: from mail-bn1bon0093.outbound.protection.outlook.com ([157.56.111.93]:41137 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755101AbcEZVIX (ORCPT ); Thu, 26 May 2016 17:08:23 -0400 Authentication-Results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Fri, 27 May 2016 00:08:13 +0300 From: Yury Norov To: "Zhangjian (Bamvor)" CC: , , , , , , , , , , , , , , , , , , , , , , Hanjun Guo Subject: Re: [PATCH 16/23] arm64: ilp32: introduce binfmt_ilp32.c Message-ID: <20160526210813.GC10274@yury-N73SV> References: <1464048292-30136-1-git-send-email-ynorov@caviumnetworks.com> <1464048292-30136-17-git-send-email-ynorov@caviumnetworks.com> <5746FEF6.9070405@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5746FEF6.9070405@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [50.233.148.158] X-ClientProxiedBy: BLUPR18CA0010.namprd18.prod.outlook.com (10.162.230.20) To CY1PR07MB2232.namprd07.prod.outlook.com (10.164.112.146) X-MS-Office365-Filtering-Correlation-Id: b1bb18d9-6c94-4851-8d16-08d385a9dcff X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2232;2:Nz1cw7lDghhw7WrOA7v+j22oP0iVk1xf9h6x15vUvuBpJcV36D33kNt6PxWHLnH9VjlF/NSbCng1vzkcXUUwsOmTKcdxM3aTwRYWhUuCtigNEWzg7raEMVtW/P1ETABLw7Fkb45KptT6yfGeLESE6bPYEX3VNS2isX8jUu/cPasmmCPfVBm7aEYopfeSPMU5;3:IJEQYM5Zg2pqIr3HJthG0S2WBkAFgVLMBsJIqZvVCy0h94KfKRnthvcZAMh3uCg7WORe+q0vCmkzYH1mhgFqqeFcE3uqG65Po+gtko3DsrKL32jrxaAlhCZpzbBeQhf6;25:/OSGtQBg7Ub+Wg0tC7twlWJbINBwO9yuQUO7y16qywwAAR/U+2cMBoJH50joSVcHbYG3bxPXrM3rUfo44Xt3+ZuU/zVEwcXQS9uAZRVpOfFt17jfH5ykA1ZQxHUDHx91LOgpqHlNgDHLCybMh08XtKYfQnrWNycTBDkVtgo6qpRLg9ysBSlFvLPyir6HvI9RjyoJdku870IC17w9i3Ym7ZhLuBflAcWB20Cf3GnYk1KFYeIpxMqGTAo0u7yy4cF81gHCYvsj0zKFkrwjhkZLQ1kccY/Oev7wzfQ/2JZiBoJHObVfmr47x9Jpo2+FoU997ntttDqMdg77OougqzOtSbdDsXgIGhns59Z0A3nF/fxNFcDARMzR5pV8fVu0AZuPtHLu8z9y/1XKywwr1MCX5EeRf6yGK6pHCxo2m8Z5WPc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2232; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2232;20:OIYu2HrLV27uEKFUcOzWXlqtUHfQ5v2qllsco0PNsfvDUNhMzdKpOoa9TXMmq3n6Vn2BglFf+nZ3hCmCTA8kpC2ok6lHg7r3Fey36sYiSr8AUDTu1Cu3c3x9NjW4cDGaiMQ9qnt9aoq8RksZKoCCgdFZj1aox2+uKcIA3ykU37pXF3e/NPrMyJCbk7o+ONtoslPQSwAPt8nK0a3TElLknMiuGsRJ14UcXGJ0EmAmScbO85IJkQV9emD3yzluLv3uT/SrNgGR/gusnRgmK9kAKpziEfaxgtry6YCS3n0DXEaWuhzKujMNraunqMTRIcnr5SJ2TEqzIyuXe+0uzUP4rj5gvBeVIibO86XELHZ2couJF8Z99tJKXWADqFOb891+1u16qk82cPwPRxVrIoXhhhPzX40lsZGUV6Uwtu2IZ0YpplcF79FfQW0Hqluhj068J+VKEYCjuT67NauitrUaNnSSPidUjR0WzkBVW+KBQypRppoDeo0PR/pIkTvTr35j5CV/lyIqe3eVWJ9V7LNiwahnkj/rkoAGWqpbcsa6hArlzQYko+EpDGCtTS5+z20iwm52+BoJkwupKVhoyOrofeOy5iViyKU2yGWfwONUFkY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(50582790962513); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY1PR07MB2232;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2232; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2232;4:mu/hz5ttoYPC5lmKcb74jd5ErXG89EZDQhpc3CE19NSpEKyJeQIJRlcSiNiBPit+iDPX22emfq9l7fOx4nHnkxvHx8J+H57erIHceU6WKYl0bgnJHhA/imLD+yCJz15sHLPc9KW1A7MOF6WSjrKrjPKTk2bZlRV7ltTeLk2FiEc41LsPZbuYU8o5W/PfJvYoyflSOW6zZQgzYZTvmn0QtxN/o0WOfzczkICs5zym4B1ivi8BqvUHPrxuiTuIqHWOKm1OZcwXd5LvMJnDSfU2f8kdraVD0MWg+g645tps6Bm/xxNeSuMWC5sfDGdjxXKFKeVqWqrNIUuoSpUMgO8D1eieawxhlOKi8R52gwWQbZR4tGsb9drAlO4RNH4GMo/Rno7FEng5dlAUMM7VFT4ScHXhiDD5zK2qS0ermaQnNxQ= X-Forefront-PRVS: 0954EE4910 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(24454002)(92566002)(83506001)(8676002)(47776003)(76176999)(50986999)(54356999)(5008740100001)(33656002)(4001350100001)(9686002)(23726003)(110136002)(76506005)(81166006)(189998001)(5004730100002)(46406003)(586003)(6116002)(2906002)(42186005)(1076002)(33716001)(50466002)(66066001)(19580405001)(2950100001)(4326007)(77096005)(19580395003)(3846002)(97756001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2232;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR07MB2232;23:qbkjjtjqwGNePjlfluB9rNDSk0AezoUPeu0Jtfmvh?= =?us-ascii?Q?axn65CdK7HcWtiWRwMECp4whj3yuhdEvVNf69b+RrtKwuv00WPuRhQ3zxMLG?= =?us-ascii?Q?Hy27oCiMcPPFcNjaj9+uMxTBg2putWNt00tescI18VGCiNvSiAOfnV3sJFEc?= =?us-ascii?Q?34gXGSFNAbxhqG+TWGUX0/If63bi3gUlmn/vxZYepMGANH8HsgkN9NGedN+s?= =?us-ascii?Q?J7u3OOJ2d1c8TDXMvmIDG35Cgdg4dRfRqmRKD/vCDv7mlPplpWMQuxYQOKVP?= =?us-ascii?Q?VqUm1cdwVxYKM+vmkQfpFLgS22byrkP1KVn29iIueLVbFlyJRC9k3wwhs9Qk?= =?us-ascii?Q?zStOuM3ZFRB3ltKtJtR0BlEmzEU71rR3+OUihqH6oVWRSmpH0ReSicND3cTG?= =?us-ascii?Q?Tq65CnM1r9DCFuKpl9vrGjmBv017pNohtyokvsJcuANU7/bRwrWEs4vD66zZ?= =?us-ascii?Q?DvI1DxsCGaI6p0G2gQlH5DPDR34F3S+cTdedgm5wKuY3ti3RC0zhz1ST1GpK?= =?us-ascii?Q?9Qx6LM3WNwE1wIPLKwbsftJd9XASynC/KwuhlEUtbTmuGUoLKa43hcZV94hh?= =?us-ascii?Q?/QnefyAqjwHanI3aQc9DbWsyjb80gFiWW8+BTOg+RvIKQ/aCSKNl8urQcvl6?= =?us-ascii?Q?mz098AbQcBqLx6I9eR4HQVqbAiZV+1uQFGOSPDZn/Ka2FJoH992MOmbG2yV6?= =?us-ascii?Q?91Fr/UV6nexNuFwN7vCNRkyl6w8M8XqFMsg03VxWigdm/EWF5VhNXrnlHIZV?= =?us-ascii?Q?rek6Lamc9y5eJ64n7RvPH8sHvjWys6hGx5q8+OMfWf3kBdWCVpYxp+SgmR8x?= =?us-ascii?Q?f5KKEdyLUNJMPjV0kWqDabwKwwGoPhDSnlooe0T+TkykfWGbrSfn62UD523T?= =?us-ascii?Q?xjbklO6cLrEUPj30HBdi2xTtR1vn99X/t2M/+V2r96c9fJYwcZTnqJ4fZrmb?= =?us-ascii?Q?sKWKeEkxOBczeSD7/81aYkVdD9bbBEr6GGLaWw90YenKPT/Ns/iukiEN3LuF?= =?us-ascii?Q?nA=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2232;5:u6pzo3IuFMAvx/8Uk5UzVp2Oo8ZXHmR7tTgarKtKmSkHnhUiQfKFQbZHnyVKBp9w3f9XPEdFxd0Geb86EhLWenMpjh6y4wS5vvZ9iioxYm/qdhVjCa12xV6QLeya68+3oCvTo/wDDg8HxUOiNuF0FQ==;24:ZmGqaX7zFQJkpZxEf2126sJdxD9Q+290e7RdK0435lL7hUWulyR9yTv14xFcWXb31PcPhddmNyOFK2f6fC5QbvAdNixBd3qWxWSCjU3asVc=;7:BD7I36nWJUPiIbnLfT6pxlffJKa/mN85crbShRZBTvOgHyCZ7tepyiedeCZeRc6ZW2+pbBz7JtBADkzfhyq32Y7avrSqV27FJb/pnLiRyKVylIPKCc8YhGBwcPWmcPQuxLP8uyMF82UJmJMaKdn/QUttEEB/rzpqGROpZDDyhxISAO9h2/7otAJuM/sy55Uf SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2016 21:08:18.9949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2232 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 26, 2016 at 09:49:42PM +0800, Zhangjian (Bamvor) wrote: > Hi, yury > > The coredump is usable in our platform. It miss the following definition: > +#define compat_elf_greg_t elf_greg_t > +#define compat_elf_gregset_t elf_gregset_t > > And it leads to the wrong register save in core dump. After apply this patch, > gdb could debug core dump files. > > Here is the full patch: > From 102624840aa5dacdd1bbfe3b390290f52f530ea2 Mon Sep 17 00:00:00 2001 > From: Bamvor Jian Zhang > Date: Thu, 26 May 2016 21:00:16 +0800 > Subject: [PATCH hulk-4.1-next] arm64: ilp32: fix coredump issue > > ILP32 use aarch64 register and 32bit signal struct which means it > could not make use of the existing compat_elf_prstatus/elf_prstatus > and compat_elf_prpsinfo/elf_prpsinfo. > > This patch fix this issue by introducing the different > compat_elf_greg_t, compat_elf_gregset_t for aarch64 ilp32 and aarch32 > el0. > > Tested pass on huawei's hardware in bigendian. > > Signed-off-by: Bamvor Jian Zhang > --- > arch/arm64/include/asm/elf.h | 14 +++++++------- > arch/arm64/kernel/binfmt_elf32.c | 3 +++ > arch/arm64/kernel/binfmt_ilp32.c | 8 +++++++- > arch/arm64/kernel/ptrace.c | 20 ++++++++++---------- > 4 files changed, 27 insertions(+), 18 deletions(-) > > diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h > index 0106d18..9019441 100644 > --- a/arch/arm64/include/asm/elf.h > +++ b/arch/arm64/include/asm/elf.h > @@ -154,18 +154,18 @@ extern int arch_setup_additional_pages(struct linux_binprm *bprm, > int uses_interp); > > /* 1GB of VA */ > -#define STACK_RND_MASK (is_compat_task() ? \ > - 0x7ff >> (PAGE_SHIFT - 12) : \ > - 0x3ffff >> (PAGE_SHIFT - 12)) > +#define STACK_RND_MASK (is_compat_task() ? \ > + 0x7ff >> (PAGE_SHIFT - 12) : \ > + 0x3ffff >> (PAGE_SHIFT - 12)) > > #ifdef CONFIG_COMPAT > > -#define COMPAT_ELF_ET_DYN_BASE (2 * TASK_SIZE_32 / 3) > +#define COMPAT_ELF_ET_DYN_BASE (2 * TASK_SIZE_32 / 3) > > /* AArch32 registers. */ > -#define COMPAT_ELF_NGREG 18 > -typedef unsigned int compat_elf_greg_t; > -typedef compat_elf_greg_t compat_elf_gregset_t[COMPAT_ELF_NGREG]; > +#define COMPAT_ELF_NGREG 18 > +typedef unsigned int compat_a32_elf_greg_t; > +typedef compat_a32_elf_greg_t compat_a32_elf_gregset_t[COMPAT_ELF_NGREG]; > > #endif /* CONFIG_COMPAT */ > > diff --git a/arch/arm64/kernel/binfmt_elf32.c b/arch/arm64/kernel/binfmt_elf32.c > index 7b9b445..f75253c 100644 > --- a/arch/arm64/kernel/binfmt_elf32.c > +++ b/arch/arm64/kernel/binfmt_elf32.c > @@ -31,4 +31,7 @@ struct linux_binprm; > extern int aarch32_setup_vectors_page(struct linux_binprm *bprm, > int uses_interp); > > +#define compat_elf_greg_t compat_a32_elf_greg_t > +#define compat_elf_gregset_t compat_a32_elf_gregset_t > + > #include "../../../fs/compat_binfmt_elf.c" > diff --git a/arch/arm64/kernel/binfmt_ilp32.c b/arch/arm64/kernel/binfmt_ilp32.c > index b827a9a..01baf83 100644 > --- a/arch/arm64/kernel/binfmt_ilp32.c > +++ b/arch/arm64/kernel/binfmt_ilp32.c > @@ -2,7 +2,9 @@ > * Support for ILP32 Linux/aarch64 ELF binaries. > */ > > -#include > +#include > +#include > +#include > #include > > #undef ELF_CLASS > @@ -30,9 +32,13 @@ > * The machine-dependent core note format types are defined in elfcore-compat.h, > * which requires asm/elf.h to define compat_elf_gregset_t et al. > */ > +#define compat_elf_greg_t elf_greg_t > +#define compat_elf_gregset_t elf_gregset_t > #define elf_prstatus compat_elf_prstatus > #define elf_prpsinfo compat_elf_prpsinfo > > +#include > + > /* > * Compat version of cputime_to_compat_timeval, perhaps this > * should be an inline in . > diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c > index 5c86135..9784c77 100644 > --- a/arch/arm64/kernel/ptrace.c > +++ b/arch/arm64/kernel/ptrace.c > @@ -913,8 +913,8 @@ static const struct user_regset aarch32_regsets[] = { > [REGSET_COMPAT_GPR] = { > .core_note_type = NT_PRSTATUS, > .n = COMPAT_ELF_NGREG, > - .size = sizeof(compat_elf_greg_t), > - .align = sizeof(compat_elf_greg_t), > + .size = sizeof(compat_a32_elf_greg_t), > + .align = sizeof(compat_a32_elf_greg_t), > .get = compat_gpr_get, > .set = compat_gpr_set > }, > @@ -947,7 +947,7 @@ static int compat_ptrace_read_user(struct task_struct *tsk, compat_ulong_t off, > tmp = tsk->mm->start_data; > else if (off == COMPAT_PT_TEXT_END_ADDR) > tmp = tsk->mm->end_code; > - else if (off < sizeof(compat_elf_gregset_t)) > + else if (off < sizeof(compat_a32_elf_gregset_t)) > return copy_regset_to_user(tsk, &user_aarch32_view, > REGSET_COMPAT_GPR, off, > sizeof(compat_ulong_t), ret); > @@ -968,7 +968,7 @@ static int compat_ptrace_write_user(struct task_struct *tsk, compat_ulong_t off, > if (off & 3 || off >= COMPAT_USER_SZ) > return -EIO; > > - if (off >= sizeof(compat_elf_gregset_t)) > + if (off >= sizeof(compat_a32_elf_gregset_t)) > return 0; > > set_fs(KERNEL_DS); > @@ -1116,9 +1116,11 @@ static long compat_a32_ptrace(struct task_struct *child, compat_long_t request, > unsigned long addr = caddr; > unsigned long data = cdata; > void __user *datap = compat_ptr(data); > + unsigned int pr_reg_size = sizeof(compat_a32_elf_gregset_t); > int ret; > > switch (request) { > + > case PTRACE_PEEKUSR: > ret = compat_ptrace_read_user(child, addr, datap); > break; > @@ -1130,17 +1132,15 @@ static long compat_a32_ptrace(struct task_struct *child, compat_long_t request, > case COMPAT_PTRACE_GETREGS: > ret = copy_regset_to_user(child, > &user_aarch32_view, > - REGSET_COMPAT_GPR, > - 0, sizeof(compat_elf_gregset_t), > - datap); > + REGSET_COMPAT_GPR, 0, > + pr_reg_size, datap); > break; > > case COMPAT_PTRACE_SETREGS: > ret = copy_regset_from_user(child, > &user_aarch32_view, > - REGSET_COMPAT_GPR, > - 0, sizeof(compat_elf_gregset_t), > - datap); > + REGSET_COMPAT_GPR, 0, > + pr_reg_size, datap); > break; > > case COMPAT_PTRACE_GET_THREAD_AREA: > -- > 1.8.4.5 > > > On 2016/5/24 8:04, Yury Norov wrote: > >to handle ILP32 binaries > > > >Signed-off-by: Yury Norov > >--- > > arch/arm64/kernel/Makefile | 1 + > > arch/arm64/kernel/binfmt_ilp32.c | 91 ++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 92 insertions(+) > > create mode 100644 arch/arm64/kernel/binfmt_ilp32.c > > > >diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile > >index 6bc9738..9dfdf86 100644 > >--- a/arch/arm64/kernel/Makefile > >+++ b/arch/arm64/kernel/Makefile > >@@ -28,6 +28,7 @@ $(obj)/%.stub.o: $(obj)/%.o FORCE > > arm64-obj-$(CONFIG_AARCH32_EL0) += sys32.o kuser32.o signal32.o \ > > sys_compat.o entry32.o \ > > ../../arm/kernel/opcodes.o binfmt_elf32.o > >+arm64-obj-$(CONFIG_ARM64_ILP32) += binfmt_ilp32.o > > arm64-obj-$(CONFIG_FUNCTION_TRACER) += ftrace.o entry-ftrace.o > > arm64-obj-$(CONFIG_MODULES) += arm64ksyms.o module.o > > arm64-obj-$(CONFIG_ARM64_MODULE_PLTS) += module-plts.o > >diff --git a/arch/arm64/kernel/binfmt_ilp32.c b/arch/arm64/kernel/binfmt_ilp32.c > >new file mode 100644 > >index 0000000..a934fd4 > >--- /dev/null > >+++ b/arch/arm64/kernel/binfmt_ilp32.c > >@@ -0,0 +1,91 @@ > >+/* > >+ * Support for ILP32 Linux/aarch64 ELF binaries. > >+ */ > >+ > >+#include > >+#include > >+ > >+#undef ELF_CLASS > >+#define ELF_CLASS ELFCLASS32 > >+ > >+#undef elfhdr > >+#undef elf_phdr > >+#undef elf_shdr > >+#undef elf_note > >+#undef elf_addr_t > >+#define elfhdr elf32_hdr > >+#define elf_phdr elf32_phdr > >+#define elf_shdr elf32_shdr > >+#define elf_note elf32_note > >+#define elf_addr_t Elf32_Addr > >+ > >+/* > >+ * Some data types as stored in coredump. > >+ */ > >+#define user_long_t compat_long_t > >+#define user_siginfo_t compat_siginfo_t > >+#define copy_siginfo_to_user copy_siginfo_to_user32 > >+ > >+/* > >+ * The machine-dependent core note format types are defined in elfcore-compat.h, > >+ * which requires asm/elf.h to define compat_elf_gregset_t et al. > >+ */ > >+#define elf_prstatus compat_elf_prstatus > >+#define elf_prpsinfo compat_elf_prpsinfo > >+ > >+/* > >+ * Compat version of cputime_to_compat_timeval, perhaps this > >+ * should be an inline in . > >+ */ > >+static void cputime_to_compat_timeval(const cputime_t cputime, > >+ struct compat_timeval *value) > >+{ > >+ struct timeval tv; > >+ cputime_to_timeval(cputime, &tv); > >+ value->tv_sec = tv.tv_sec; > >+ value->tv_usec = tv.tv_usec; > >+} > >+ > >+#undef cputime_to_timeval > >+#define cputime_to_timeval cputime_to_compat_timeval > >+ > >+/* AARCH64 ILP32 EABI. */ > >+#undef elf_check_arch > >+#define elf_check_arch(x) (((x)->e_machine == EM_AARCH64) \ > >+ && (x)->e_ident[EI_CLASS] == ELFCLASS32) > >+ > >+#undef SET_PERSONALITY > >+#define SET_PERSONALITY(ex) \ > >+do { \ > >+ set_thread_flag(TIF_32BIT_AARCH64); \ > >+ clear_thread_flag(TIF_32BIT); \ > >+} while (0) > >+ > >+#undef ARCH_DLINFO > >+#define ARCH_DLINFO \ > >+do { \ > >+ NEW_AUX_ENT(AT_SYSINFO_EHDR, \ > >+ (elf_addr_t)(long)current->mm->context.vdso); \ > >+} while (0) > >+ > >+#ifdef __AARCH64EB__ > >+#define COMPAT_ELF_PLATFORM ("aarch64_be:ilp32") > >+#else > >+#define COMPAT_ELF_PLATFORM ("aarch64:ilp32") > >+#endif > >+ > >+#undef ELF_HWCAP > >+#undef ELF_HWCAP2 > >+#define ELF_HWCAP ((u32) elf_hwcap) > >+#define ELF_HWCAP2 ((u32) (elf_hwcap >> 32)) > >+ > >+/* > >+ * Rename a few of the symbols that binfmt_elf.c will define. > >+ * These are all local so the names don't really matter, but it > >+ * might make some debugging less confusing not to duplicate them. > >+ */ > >+#define elf_format compat_elf_format > >+#define init_elf_binfmt init_compat_elf_binfmt > >+#define exit_elf_binfmt exit_compat_elf_binfmt > >+ > >+#include "../../../fs/binfmt_elf.c" > > Thank you, I'll apply it