From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932691AbcE0IAs (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 May 2016 04:00:48 -0400
Received: from mail-pf0-f193.google.com ([209.85.192.193]:35824 "EHLO
	mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932516AbcE0IAf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 May 2016 04:00:35 -0400
Date: Fri, 27 May 2016 17:00:26 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>, linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH 4/7] zram: align zcomp interface to crypto comp API
Message-ID: <20160527080026.GD504@swordfish>
References: <20160525143006.1207-1-sergey.senozhatsky@gmail.com>
 <20160525143006.1207-5-sergey.senozhatsky@gmail.com>
 <20160527043137.GD2322@bbox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160527043137.GD2322@bbox>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (05/27/16 13:31), Minchan Kim wrote:
[..]
> >  int zcomp_compress(struct zcomp_strm *zstrm,
> > -		const unsigned char *src, unsigned int *dst_len)
> > +		const u8 *src, unsigned int *dst_len)
> 
> Nitpick:
> 
> The zcomp doesn't need to depend on implementation(i.e., crypto) so
> zcomp_compress should pass void * for src and dst.
> 
> I'm not strong aginst changing u8 but your description makes me
> think about that. 

no strong opinion on this either.

	-ss