From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756608AbcE0UaF (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 May 2016 16:30:05 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:44406 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752880AbcE0UaB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 May 2016 16:30:01 -0400
Date: Fri, 27 May 2016 13:30:00 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: "Shi, Yang" <yang.shi@linaro.org>
Cc: Minchan Kim <minchan@kernel.org>, iamjoonsoo.kim@lge.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] mm: check the return value of lookup_page_ext for all
 call sites
Message-Id: <20160527133000.84a887b7ce8d2e6387145b4d@linux-foundation.org>
In-Reply-To: <ab9cf30c-4979-07af-6732-e647078ef579@linaro.org>
References: <1464023768-31025-1-git-send-email-yang.shi@linaro.org>
	<20160524025811.GA29094@bbox>
	<20160526003719.GB9661@bbox>
	<8ae0197c-47b7-e5d2-20c3-eb9d01e6b65c@linaro.org>
	<20160527130246.4adb78f29e15d19fae80419a@linux-foundation.org>
	<ab9cf30c-4979-07af-6732-e647078ef579@linaro.org>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 27 May 2016 13:17:19 -0700 "Shi, Yang" <yang.shi@linaro.org> wrote:

> >> Actually, I think the #ifdef should be removed if lookup_page_ext() is
> >> possible to return NULL. It sounds not make sense returning NULL only
> >> when DEBUG_VM is enabled. It should return NULL no matter what debug
> >> config is selected. If Joonsoo agrees with me I'm going to come up with
> >> a patch to fix it.
> >>
> >
> > I've lost the plot here.  What is the status of this patch?
> >
> > Latest version:
> 
> Yes, this is the latest version. We are discussing about some future 
> optimization.
> 
> And, Minchan Kim pointed out a possible race condition which exists even 
> before this patch. I proposed a quick fix, as long as they are happy to 
> the fix, I will post it to the mailing list.

OK, thanks - I've moved it into the for-Linus-next-week queue.