From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756448AbcE0SM1 (ORCPT ); Fri, 27 May 2016 14:12:27 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:33989 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753402AbcE0SMZ (ORCPT ); Fri, 27 May 2016 14:12:25 -0400 Date: Fri, 27 May 2016 11:12:19 -0700 From: Guenter Roeck To: William Breathitt Gray Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org, x86@kernel.org, linux-next@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, sfr@canb.auug.org.au, Linus Torvalds Subject: Re: [PATCH v4 1/4] isa: Allow ISA-style drivers on modern systems Message-ID: <20160527181219.GA19472@roeck-us.net> References: <4cc7af2b90cdff1c9e680fb2c2cd81882c6695d2.1464049539.git.vilhelm.gray@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4cc7af2b90cdff1c9e680fb2c2cd81882c6695d2.1464049539.git.vilhelm.gray@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2016 at 08:30:44PM -0400, William Breathitt Gray wrote: > Several modern devices, such as PC/104 cards, are expected to run on > modern systems via an ISA bus interface. Since ISA is a legacy interface > for most modern architectures, ISA support should remain disabled in > general. Support for ISA-style drivers should be enabled on a per driver > basis. > > To allow ISA-style drivers on modern systems, this patch introduces the > ISA_BUS_API and ISA_BUS Kconfig options. The ISA bus driver will now > build conditionally on the ISA_BUS_API Kconfig option, which defaults to > the legacy ISA Kconfig option. The ISA_BUS Kconfig option allows the > ISA_BUS_API Kconfig option to be selected on architectures which do not > enable ISA (e.g. X86_64). > > The ISA_BUS Kconfig option is currently only implemented for X86 > architectures. Other architectures may have their own ISA_BUS Kconfig > options added as required. > > Cc: Linus Torvalds > Signed-off-by: William Breathitt Gray FWIW, looks good to me. Reviewed-by: Guenter Roeck > --- > arch/Kconfig | 3 +++ > arch/x86/Kconfig | 9 +++++++++ > drivers/base/Makefile | 2 +- > include/linux/isa.h | 2 +- > 4 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index b16e74e..9d9942f 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -598,6 +598,9 @@ config HAVE_STACK_VALIDATION > Architecture supports the 'objtool check' host tool command, which > performs compile-time stack metadata validation. > > +config ISA_BUS_API > + def_bool ISA > + > # > # ABI hall of shame > # > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 0a7b885..d9a94da 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2439,6 +2439,15 @@ config PCI_CNB20LE_QUIRK > > source "drivers/pci/Kconfig" > > +config ISA_BUS > + bool "ISA-style bus support on modern systems" if EXPERT > + select ISA_BUS_API > + help > + Enables ISA-style drivers on modern systems. This is necessary to > + support PC/104 devices on X86_64 platforms. > + > + If unsure, say N. > + > # x86_64 have no ISA slots, but can have ISA-style DMA. > config ISA_DMA_API > bool "ISA-style DMA support" if (X86_64 && EXPERT) > diff --git a/drivers/base/Makefile b/drivers/base/Makefile > index 6b2a84e..2609ba2 100644 > --- a/drivers/base/Makefile > +++ b/drivers/base/Makefile > @@ -10,7 +10,7 @@ obj-$(CONFIG_DMA_CMA) += dma-contiguous.o > obj-y += power/ > obj-$(CONFIG_HAS_DMA) += dma-mapping.o > obj-$(CONFIG_HAVE_GENERIC_DMA_COHERENT) += dma-coherent.o > -obj-$(CONFIG_ISA) += isa.o > +obj-$(CONFIG_ISA_BUS_API) += isa.o > obj-$(CONFIG_FW_LOADER) += firmware_class.o > obj-$(CONFIG_NUMA) += node.o > obj-$(CONFIG_MEMORY_HOTPLUG_SPARSE) += memory.o > diff --git a/include/linux/isa.h b/include/linux/isa.h > index 5ab8528..384ab9b 100644 > --- a/include/linux/isa.h > +++ b/include/linux/isa.h > @@ -22,7 +22,7 @@ struct isa_driver { > > #define to_isa_driver(x) container_of((x), struct isa_driver, driver) > > -#ifdef CONFIG_ISA > +#ifdef CONFIG_ISA_BUS_API > int isa_register_driver(struct isa_driver *, unsigned int); > void isa_unregister_driver(struct isa_driver *); > #else > -- > 2.7.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html