From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755265AbcE0UxH (ORCPT ); Fri, 27 May 2016 16:53:07 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:33141 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbcE0UxD (ORCPT ); Fri, 27 May 2016 16:53:03 -0400 Date: Fri, 27 May 2016 13:52:55 -0700 From: Guenter Roeck To: William Breathitt Gray Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org, x86@kernel.org, linux-next@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, sfr@canb.auug.org.au, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Cameron Subject: Re: [PATCH v4 3/4] iio: stx104: Allow build for X86_64 Message-ID: <20160527205255.GA27341@roeck-us.net> References: <20160527182057.GC19472@roeck-us.net> <20160527195400.GA12494@sophia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160527195400.GA12494@sophia> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 27, 2016 at 03:54:00PM -0400, William Breathitt Gray wrote: > On Fri, May 27, 2016 at 11:20:57AM -0700, Guenter Roeck wrote: > >On Mon, May 23, 2016 at 08:31:07PM -0400, William Breathitt Gray wrote: > >> With the introduction of the ISA_BUS_API Kconfig option, ISA-style > >> drivers may be built for X86_64 architectures. This patch changes the > >> ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC > >> driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is > >> expected to. > >> > >> Cc: Hartmut Knaack > >> Cc: Lars-Peter Clausen > >> Cc: Peter Meerwald-Stadler > >> Cc: Jonathan Cameron > >> Signed-off-by: William Breathitt Gray > >> --- > >> drivers/iio/dac/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig > >> index e63b957..315442f 100644 > >> --- a/drivers/iio/dac/Kconfig > >> +++ b/drivers/iio/dac/Kconfig > >> @@ -247,7 +247,7 @@ config MCP4922 > >> > >> config STX104 > >> tristate "Apex Embedded Systems STX104 DAC driver" > >> - depends on X86 && ISA > >> + depends on ISA_BUS_API > > > >Assuming the dropped dependency on X86 is intentional: > > > >Reviewed-by: Guenter Roeck > > Thanks for the review Guenter: losing the X86 dependency was not > intentional; it looks like I forgot to adjust this when I made > ISA_BUS_API available to all architectures. I'll submit version 5 with > the explicit X86 dependency back in place for CONFIG_STX104 and > CONFIG_EBC_C384_WDT. > Ok. Feel free to keep my Reviewed-by: tag unless you make further changes. Guenter