From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751854AbcE1Lsy (ORCPT <rfc822;w@1wt.eu>);
	Sat, 28 May 2016 07:48:54 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34603 "EHLO
	out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750778AbcE1Lsw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 28 May 2016 07:48:52 -0400
X-Sasl-enc: KyzKITpmIbpfuWQJe8fw143iRNOoHW2U6ujSccvZnchm 1464436130
Date: Sat, 28 May 2016 08:48:46 -0300
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Scot Doyle <lkml14@scotdoyle.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jeremy Kerr <jk@ozlabs.org>, Ming Lei <ming.lei@canonical.com>,
        David Daney <david.daney@cavium.com>,
        Dann Frazier <dann.frazier@canonical.com>,
        Peter Hurley <peter@hurleysoftware.com>, Pavel Machek <pavel@ucw.cz>,
        Jonathan Liu <net147@gmail.com>,
        Alistair Popple <alistair@popple.id.au>,
        Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
        "Chintakuntla, Radha" <Radha.Chintakuntla@caviumnetworks.com>,
        Jiri Slaby <jslaby@suse.com>, David Airlie <airlied@linux.ie>,
        David Daney <ddaney.cavm@gmail.com>, dri-devel@lists.freedesktop.org,
        linux-fbdev@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        stable <stable@vger.kernel.org>
Subject: Re: [PATCH] fbcon: warn on invalid cursor blink intervals
Message-ID: <20160528114846.GC13329@khazad-dum.debian.net>
References: <ed8fa4ca-49e0-3ff4-5499-fc5250dd8ae2@caviumnetworks.com>
 <alpine.DEB.2.10.1605182252230.12118@laptop>
 <573DE2D0.1050402@caviumnetworks.com>
 <alpine.DEB.2.10.1605191708400.15396@laptop>
 <alpine.DEB.2.10.1605191726030.15478@laptop>
 <CACVXFVM77CaHGE9kwhaxoa-fuNxZrDDzpCdHfnRno857pQANZQ@mail.gmail.com>
 <573E75CD.6050202@ozlabs.org>
 <CACVXFVPRiOShXHNCQsDe_0AoC++wQAfix3OTjyKC4spu1r9LvQ@mail.gmail.com>
 <573E9AE5.1020206@ozlabs.org>
 <alpine.DEB.2.10.1605200937330.18587@laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.10.1605200937330.18587@laptop>
X-GPG-Fingerprint1: 4096R/39CB4807 C467 A717 507B BAFE D3C1  6092 0BD9 E811
 39CB 4807
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 20 May 2016, Scot Doyle wrote:
> On Fri, 20 May 2016, Jeremy Kerr wrote:
> > >Then looks there are two fix patches acked & tested:
> > >
> > > - the patch in this thread
> > > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor
> > >blink timer."
> > > https://lkml.org/lkml/2016/5/17/455
> > >
> > >So which one will be pushed to linus?
> > 
> > Not that it's my call, but we may want both; the first as a safety
> > measure to prevent an invalid cur_blink_jiffies ever being set, and the
> > second one to actually fix the initialisation of vc_cur_blink_ms (and
> > address the warning introduced by the first).
> 
> Tomi / Greg,
> 
> I'd suggest
> - applying "tty: vt: Fix soft lockup in fbcon cursor blink timer." to 4.7 and stable[4.2]
> - applying "fbcon: warn on invalid cursor blink intervals" to 4.7
> - ignoring "fbcon: use default if cursor blink interval is not valid"
> 
> Note: the patches don't depend on each other

I applied both recommended patches on top of 4.4.11 for testing, and they
made things a lot better here.

I suggest the second patch should be backported to stable too, might as well
fix this thing for good *and keep the door closed*.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh