From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752820AbcE1MDb (ORCPT <rfc822;w@1wt.eu>);
	Sat, 28 May 2016 08:03:31 -0400
Received: from mail-pa0-f66.google.com ([209.85.220.66]:36280 "EHLO
	mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752515AbcE1MDE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 28 May 2016 08:03:04 -0400
Date: Sat, 28 May 2016 20:02:59 +0800
From: Minfei Huang <mnghuan@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>, Borislav Petkov <bp@suse.de>,
        Andrew Lutomirski <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] pvclock: Add a new wrapper function to only get
 variable flags
Message-ID: <20160528120259.GA7163@dhcp-128-8.nay.redhat.com>
References: <1464329832-4638-1-git-send-email-mnghuan@gmail.com>
 <1464329832-4638-3-git-send-email-mnghuan@gmail.com>
 <CALCETrXGVjiyE1dWe0_1N3v+-5SO7GqEazfVE4Uhqz9c4QxgSA@mail.gmail.com>
 <9d18b1a3-90b4-6969-6bda-b7556d8264a6@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9d18b1a3-90b4-6969-6bda-b7556d8264a6@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/27/16 at 06:06P, Paolo Bonzini wrote:
> 
> 
> On 27/05/2016 17:40, Andy Lutomirski wrote:
> > On Thu, May 26, 2016 at 11:17 PM, Minfei Huang <mnghuan@gmail.com> wrote:
> >> There is a generic function __pvclock_read_cycles to be used to get both
> >> flags and cycles. For function pvclock_read_flags, it's useless to get
> >> cycles value. To make this function be more effective, add a new wrapper
> >> function to only get variable flags.
> > 
> > Why not just get rid of this function entirely?
> 
> I agree.  If you want to abstract the retry logic, perhaps you can add

Hmm, I will get rid of pvclock_read_flags, and repost it.

Thanks
Minfei

> pvclock_read_{begin,retry} functions like seqlock_read_{begin,retry}?
> 
> Thanks,
> 
> Paolo