From: Christoph Hellwig <hch@infradead.org>
To: Shaohua Li <shli@fb.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
sitsofe@yahoo.com, snitzer@redhat.com, axboe@fb.com,
martin.petersen@oracle.com, Kernel-team@fb.com
Subject: Re: [PATCH] block: correctly fallback for zeroout
Date: Sat, 28 May 2016 23:47:28 -0700 [thread overview]
Message-ID: <20160529064728.GA14383@infradead.org> (raw)
In-Reply-To: <20160526180813.GA49039@shli-mbp.local>
On Thu, May 26, 2016 at 11:08:14AM -0700, Shaohua Li wrote:
> -int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> - sector_t nr_sects, gfp_t gfp_mask, unsigned long flags)
> +static int do_blkdev_issue_discard(struct block_device *bdev, sector_t sector,
We've split blkdev_issue_discard into __blkdev_issue_discard and a small
wrapper around in for 4.7, so this will need a bit of an update.
As part of that I also removed the strange EOPNOTSUPP ignore, but Mike
reverted it just because it changed something in the dm testsuite.
I still believe we should never ignore it in this helper, and only
do so in callers that believe it's the right thing.
next prev parent reply other threads:[~2016-05-29 6:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 18:08 [PATCH] block: correctly fallback for zeroout Shaohua Li
[not found] ` <20160527054918.GA9521@sucs.org>
2016-05-28 9:27 ` Sitsofe Wheeler
2016-06-02 16:58 ` Shaohua Li
2016-06-02 17:02 ` Martin K. Petersen
2016-06-03 2:56 ` Martin K. Petersen
2016-05-29 6:47 ` Christoph Hellwig [this message]
2016-06-03 3:06 ` Martin K. Petersen
2016-06-03 3:54 ` Mike Snitzer
2016-06-07 2:32 ` Martin K. Petersen
2016-06-07 6:38 ` Christoph Hellwig
2016-06-10 2:05 ` Martin K. Petersen
2016-06-03 3:26 ` [PATCH] " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160529064728.GA14383@infradead.org \
--to=hch@infradead.org \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shli@fb.com \
--cc=sitsofe@yahoo.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).