From: "George Spelvin" <linux@sciencehorizons.net>
To: geert@linux-m68k.org, linux@sciencehorizons.net,
torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] test/hash: Fix warning in preprocessor symbol evaluation
Date: 29 May 2016 14:53:55 -0400 [thread overview]
Message-ID: <20160529185355.12968.qmail@ns.sciencehorizons.net> (raw)
In-Reply-To: <1464542922-7139-2-git-send-email-geert@linux-m68k.org>
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Some versions of gcc don't like tests for the value of an undefined
> preprocessor symbol, even in the #else branch of an #ifndef:
Damn, I had hoped that would work universally; I tried to avoid the
uglier #if-inside-#ifdef construction. GCC 6 is quite happy wth it.
But no objections.
If you want:
Acked-by: George Spelvin <linux@sciencehorizons.net>
But here's an alternative. Geert, what do you think of this?
diff --git a/lib/test_hash.c b/lib/test_hash.c
index c9549c8b..8ea1d2ca 100644
--- a/lib/test_hash.c
+++ b/lib/test_hash.c
@@ -221,17 +221,17 @@ test_hash_init(void)
/* Issue notices about skipped tests. */
#ifndef HAVE_ARCH__HASH_32
pr_info("__hash_32() has no arch implementation to test.");
-#elif HAVE_ARCH__HASH_32 != 1
+#elif HAVE_ARCH__HASH_32 + 0 != 1
pr_info("__hash_32() is arch-specific; not compared to generic.");
#endif
#ifndef HAVE_ARCH_HASH_32
pr_info("hash_32() has no arch implementation to test.");
-#elif HAVE_ARCH_HASH_32 != 1
+#elif HAVE_ARCH_HASH_32 + 0 != 1
pr_info("hash_32() is arch-specific; not compared to generic.");
#endif
#ifndef HAVE_ARCH_HASH_64
pr_info("hash_64() has no arch implementation to test.");
-#elif HAVE_ARCH_HASH_64 != 1
+#elif HAVE_ARCH_HASH_64 + 0 != 1
pr_info("hash_64() is arch-specific; not compared to generic.");
#endif
next prev parent reply other threads:[~2016-05-29 18:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 17:28 [PATCH 1/2] test/hash: Fix warning in two-dimensional array init Geert Uytterhoeven
2016-05-29 17:28 ` [PATCH 2/2] test/hash: Fix warning in preprocessor symbol evaluation Geert Uytterhoeven
2016-05-29 18:53 ` George Spelvin [this message]
2016-05-29 19:07 ` George Spelvin
2016-05-29 18:43 ` [PATCH 1/2] test/hash: Fix warning in two-dimensional array init George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160529185355.12968.qmail@ns.sciencehorizons.net \
--to=linux@sciencehorizons.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).