From: Namhyung Kim <namhyung@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Hemant Kumar <hemant@linux.vnet.ibm.com>,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
Brendan Gregg <brendan.d.gregg@gmail.com>
Subject: Re: [PATCH perf/core v9 00/16] perf-probe --cache and SDT support
Date: Mon, 30 May 2016 12:54:58 +0900 [thread overview]
Message-ID: <20160530035458.GA13689@danjae.aot.lge.com> (raw)
In-Reply-To: <20160528151456.16098.90001.stgit@devbox>
Hi Masami,
On Sun, May 29, 2016 at 12:15:01AM +0900, Masami Hiramatsu wrote:
> Hi,
>
> Here is the 9th version of the patchset for probe-cache and
> initial SDT support.
>
> The previous version is here; https://lkml.org/lkml/2016/5/14/107
>
> This version just fixes 2 points according to Hemant's comment,
> and split out the filename__readable() patch.
>
> Changes in v9:
> - [1/16,2/16] split out the filename__readable()
> - [7/16] Fix to show which event is deleted.
> - [12/16] Update list_usage to show sdt option.
>
> Thank you,
Thanks for doing this, I hope this gets merged soon. The patch 4 and
14 look a bit larger and would be better to be splitted IMHO. Other
than that, all look good to me.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
> ---
>
> Hemant Kumar (1):
> perf/sdt: ELF support for SDT
>
> Masami Hiramatsu (15):
> perf-symbol: Introduce filename__readable to check readability
> perf symbol: Cleanup the code flow of dso__find_kallsyms
> perf-buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid
> perf probe: Add --cache option to cache the probe definitions
> perf probe: Use cache entry if possible
> perf probe: Show all cached probes
> perf probe: Remove caches when --cache is given
> perf probe: Add group name support
> perf buildid-cache: Scan and import user SDT events to probe cache
> perf probe: Accept %sdt and %cached event name
> perf-list: Show SDT and pre-cached events
> perf-list: Skip SDTs placed in invalid binaries
> perf probe: Allow wildcard for cached events
> perf probe: Support @BUILDID or @FILE suffix for SDT events
> perf probe: Support a special SDT probe format
>
>
> tools/perf/Documentation/perf-probe.txt | 26 +-
> tools/perf/builtin-list.c | 6
> tools/perf/builtin-probe.c | 30 ++
> tools/perf/util/build-id.c | 295 ++++++++++++++++--
> tools/perf/util/build-id.h | 8
> tools/perf/util/dso.h | 5
> tools/perf/util/parse-events.c | 83 +++++
> tools/perf/util/parse-events.h | 2
> tools/perf/util/probe-event.c | 492 +++++++++++++++++++++++++++---
> tools/perf/util/probe-event.h | 7
> tools/perf/util/probe-file.c | 504 +++++++++++++++++++++++++++++++
> tools/perf/util/probe-file.h | 41 +++
> tools/perf/util/symbol-elf.c | 252 ++++++++++++++++
> tools/perf/util/symbol.c | 71 ++--
> tools/perf/util/symbol.h | 22 +
> 15 files changed, 1712 insertions(+), 132 deletions(-)
>
> --
> Masami Hiramatsu
next prev parent reply other threads:[~2016-05-30 3:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 15:15 [PATCH perf/core v9 00/16] perf-probe --cache and SDT support Masami Hiramatsu
2016-05-28 15:15 ` [PATCH perf/core v9 01/16] perf-symbol: Introduce filename__readable to check readability Masami Hiramatsu
2016-05-30 16:03 ` Arnaldo Carvalho de Melo
2016-05-30 16:04 ` Arnaldo Carvalho de Melo
2016-05-31 5:54 ` Masami Hiramatsu
2016-06-02 6:34 ` [tip:perf/core] perf symbols: " tip-bot for Masami Hiramatsu
2016-05-28 15:15 ` [PATCH perf/core v9 02/16] perf symbol: Cleanup the code flow of dso__find_kallsyms Masami Hiramatsu
2016-06-02 6:34 ` [tip:perf/core] perf symbols: " tip-bot for Masami Hiramatsu
2016-05-28 15:15 ` [PATCH perf/core v9 03/16] perf-buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid Masami Hiramatsu
2016-06-02 6:35 ` [tip:perf/core] perf buildid-cache: " tip-bot for Masami Hiramatsu
2016-05-28 15:15 ` [PATCH perf/core v9 04/16] perf probe: Add --cache option to cache the probe definitions Masami Hiramatsu
2016-05-28 15:15 ` [PATCH perf/core v9 05/16] perf probe: Use cache entry if possible Masami Hiramatsu
2016-05-28 15:16 ` [PATCH perf/core v9 06/16] perf probe: Show all cached probes Masami Hiramatsu
2016-05-28 15:16 ` [PATCH perf/core v9 07/16] perf probe: Remove caches when --cache is given Masami Hiramatsu
2016-05-28 15:16 ` [PATCH perf/core v9 08/16] perf/sdt: ELF support for SDT Masami Hiramatsu
2016-05-28 15:16 ` [PATCH perf/core v9 09/16] perf probe: Add group name support Masami Hiramatsu
2016-05-28 15:16 ` [PATCH perf/core v9 10/16] perf buildid-cache: Scan and import user SDT events to probe cache Masami Hiramatsu
2016-05-28 15:16 ` [PATCH perf/core v9 11/16] perf probe: Accept %sdt and %cached event name Masami Hiramatsu
2016-05-28 15:17 ` [PATCH perf/core v9 12/16] perf-list: Show SDT and pre-cached events Masami Hiramatsu
2016-05-28 15:17 ` [PATCH perf/core v9 13/16] perf-list: Skip SDTs placed in invalid binaries Masami Hiramatsu
2016-05-28 15:17 ` [PATCH perf/core v9 14/16] perf probe: Allow wildcard for cached events Masami Hiramatsu
2016-05-28 15:17 ` [PATCH perf/core v9 15/16] perf probe: Support @BUILDID or @FILE suffix for SDT events Masami Hiramatsu
2016-05-28 15:17 ` [PATCH perf/core v9 16/16] perf probe: Support a special SDT probe format Masami Hiramatsu
2016-05-30 3:54 ` Namhyung Kim [this message]
2016-05-30 14:31 ` [PATCH perf/core v9 00/16] perf-probe --cache and SDT support Masami Hiramatsu
2016-05-30 16:10 ` Arnaldo Carvalho de Melo
2016-05-31 9:01 ` Masami Hiramatsu
2016-05-31 13:40 ` Arnaldo Carvalho de Melo
2016-05-30 16:22 ` Arnaldo Carvalho de Melo
2016-05-30 16:30 ` Arnaldo Carvalho de Melo
2016-05-31 8:00 ` Masami Hiramatsu
2016-05-31 13:39 ` Arnaldo Carvalho de Melo
2016-05-31 16:30 ` Hemant Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530035458.GA13689@danjae.aot.lge.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=ananth@linux.vnet.ibm.com \
--cc=brendan.d.gregg@gmail.com \
--cc=hemant@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).