From: Carlo Caione <carlo@caione.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
linux-amlogic@lists.infradead.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver
Date: Mon, 30 May 2016 15:51:25 +0200 [thread overview]
Message-ID: <20160530135125.GB16188@mephisto> (raw)
In-Reply-To: <1464614948-28247-2-git-send-email-narmstrong@baylibre.com>
On 30/05/16 15:29, Neil Armstrong wrote:
> Add watchdog specific driver for Amlogic Meson GXBB SoC.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> +
> +#define GXBB_WDT_CTRL1_REG 0x4
...
> +#define GXBB_WDT_CTRL_EE_RESET_NOW BIT(26)
...
> +#define GXBB_WDT_CTRL_IRQ_EN BIT(23)
...
> +#define GXBB_WDT_CTRL_XTAL_SEL (0)
...
> +#define GXBB_WDT_CTRL_CLK81_SEL BIT(19)
...
> +#define GXBB_WDT_CTRL1_GPIO_PULSE BIT(17)
...
> +#define GXBB_WDT_CTRL1_GPIO_POL_RESET_0 BIT(16)
> +#define GXBB_WDT_CTRL1_GPIO_POL_RESET_1 (0)
> +#define GXBB_WDT_CTRL1_GPIO_PULSE_CNT (BIT(16) - 1)
nit: all these defines are not used at all in the driver. You can remove them
Thanks!
--
Carlo Caione
next prev parent reply other threads:[~2016-05-30 13:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 13:29 [PATCH 0/3] watchdog: Add Amlogic Meson GXBB Watchdog Timer driver Neil Armstrong
2016-05-30 13:29 ` [PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver Neil Armstrong
2016-05-30 13:51 ` Carlo Caione [this message]
2016-05-30 14:44 ` Guenter Roeck
2016-05-30 16:50 ` Guenter Roeck
2016-05-31 9:57 ` Neil Armstrong
2016-05-31 17:31 ` Guenter Roeck
2016-05-30 13:29 ` [PATCH 3/3] ARM64: dts: amlogic: meson-gxbb: Add watchdog node Neil Armstrong
2016-05-30 13:45 ` [PATCH 0/3] watchdog: Add Amlogic Meson GXBB Watchdog Timer driver Carlo Caione
2016-05-30 14:13 ` Neil Armstrong
2016-05-30 14:12 ` [PATCH 2/3] dt-bindings: watchdog: Add Meson GXBB Watchdog bindings Neil Armstrong
2016-06-02 22:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530135125.GB16188@mephisto \
--to=carlo@caione.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=narmstrong@baylibre.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).