From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757049AbcEaJcX (ORCPT ); Tue, 31 May 2016 05:32:23 -0400 Received: from mga09.intel.com ([134.134.136.24]:57943 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756869AbcEaJcW (ORCPT ); Tue, 31 May 2016 05:32:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,395,1459839600"; d="scan'208";a="987949442" Date: Tue, 31 May 2016 09:34:19 +0800 From: Yuyang Du To: Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, umgwanakikbuti@gmail.com, bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com Subject: Re: [RFC PATCH 2/2] sched: Remove SD_WAKE_AFFINE flag and replace it with SD_BALANCE_WAKE Message-ID: <20160531013419.GR18670@intel.com> References: <1464657098-24880-1-git-send-email-yuyang.du@intel.com> <1464657098-24880-3-git-send-email-yuyang.du@intel.com> <20160531092314.GU3192@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160531092314.GU3192@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2016 at 11:23:14AM +0200, Peter Zijlstra wrote: > On Tue, May 31, 2016 at 09:11:38AM +0800, Yuyang Du wrote: > > SD_BALANCE_{FORK|EXEC|WAKE} flags are for select_task_rq() to select a > > CPU to run a new task or a waking task. SD_WAKE_AFFINE is a flag to > > try selecting the waker CPU to run the waking task. > > > > SD_BALANCE_WAKE is not a sched_domain flag, but SD_WAKE_AFFINE is. > > No, SD_BALANCE_{FORK,EXEC,WAKE} are very much sched_domain flags. > > They indicate how wide we should look to place tasks on these events. With this patch, they are, and in particular SD_BALANCE_WAKE is. SD_WAKE_AFFINE is just a particular CPU candidate in SD_BALANCE_WAKE.