From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755593AbcEaH35 (ORCPT ); Tue, 31 May 2016 03:29:57 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:34903 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755312AbcEaH3z (ORCPT ); Tue, 31 May 2016 03:29:55 -0400 Date: Tue, 31 May 2016 08:30:22 +0100 From: Lee Jones To: Rhyland Klein Cc: Laxman Dewangan , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: max77620: Fix FPS switch statements Message-ID: <20160531073022.GA1729@dell> References: <1463075104-26924-1-git-send-email-rklein@nvidia.com> <5734C2C2.2060207@nvidia.com> <9716c1c8-dd2b-8444-6ec9-567d07fe8971@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9716c1c8-dd2b-8444-6ec9-567d07fe8971@nvidia.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 May 2016, Rhyland Klein wrote: > On 5/12/2016 1:52 PM, Laxman Dewangan wrote: > > > > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: > >> When configuring FPS during probe, assuming a DT node is present for > >> FPS, the code can run into a problem with the switch statements in > >> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, > >> in the case of chip->chip_id == MAX77620, it will set > >> fps_[mix|max]_period but then fall through to the default switch case > >> and return -EINVAL. Returning this from max77620_config_fps() will > >> cause probe to fail. > >> > > > > Thanks for fixes. > > Missed when converting if-else to switch. > > > > Reviewed-by: Laxman Dewangan > > > > Lee, I noticed this hasn't been merged yet, but without it platforms > using the max77620 can easily (if it has FPS nodes) fail to probe. Is > there anything blocking it? Yes, it was sent too late in the cycle. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog