From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH] cpufreq: stats: Make the stats code non-modular
Date: Tue, 31 May 2016 16:14:34 +0530 [thread overview]
Message-ID: <20160531104434.GE9463@vireshk-i7> (raw)
In-Reply-To: <5665576.VhylybbIm6@vostro.rjw.lan>
On 28-05-16, 15:15, Rafael J. Wysocki wrote:
> -static int __init cpufreq_stats_init(void)
> -{
> - int ret;
> - unsigned int cpu;
> -
> - spin_lock_init(&cpufreq_stats_lock);
My bad for ignoring this, but the spin lock is left uninitialized now
and this is what I get:
[ 3.335732] BUG: spinlock bad magic on CPU#0, kworker/0:0/4
[ 3.339847] lock: cpufreq_stats_lock+0x0/0x10, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
[ 3.348789] CPU: 0 PID: 4 Comm: kworker/0:0 Tainted: G W 4.7.0-rc1-00046-g6ce5bc9b2166-dirty #148
[ 3.358754] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree)
[ 3.364831] Workqueue: events dbs_work_handler
[ 3.369259] [<c010e1ac>] (unwind_backtrace) from [<c010af38>] (show_stack+0x10/0x14)
[ 3.376987] [<c010af38>] (show_stack) from [<c03248dc>] (dump_stack+0x88/0x9c)
[ 3.384191] [<c03248dc>] (dump_stack) from [<c0159b6c>] (do_raw_spin_lock+0x1ac/0x1b0)
[ 3.392089] [<c0159b6c>] (do_raw_spin_lock) from [<c0510b40>] (cpufreq_stats_update+0x24/0x60)
[ 3.400682] [<c0510b40>] (cpufreq_stats_update) from [<c0511030>] (cpufreq_stats_record_transition+0x6c/0x9c)
[ 3.410581] [<c0511030>] (cpufreq_stats_record_transition) from [<c050d4dc>] (cpufreq_notify_transition+0x94/0x13c)
[ 3.420995] [<c050d4dc>] (cpufreq_notify_transition) from [<c050d6b8>] (cpufreq_freq_transition_end+0x24/0x90)
[ 3.430975] [<c050d6b8>] (cpufreq_freq_transition_end) from [<c050e954>] (__cpufreq_driver_target+0x124/0x264)
[ 3.440957] [<c050e954>] (__cpufreq_driver_target) from [<c051159c>] (od_dbs_timer+0x9c/0x168)
[ 3.449550] [<c051159c>] (od_dbs_timer) from [<c0512060>] (dbs_work_handler+0x2c/0x60)
[ 3.457449] [<c0512060>] (dbs_work_handler) from [<c0130f68>] (process_one_work+0x124/0x338)
[ 3.465867] [<c0130f68>] (process_one_work) from [<c01311b4>] (worker_thread+0x38/0x4d4)
[ 3.473943] [<c01311b4>] (worker_thread) from [<c0136490>] (kthread+0xdc/0xf4)
[ 3.481145] [<c0136490>] (kthread) from [<c0107978>] (ret_from_fork+0x14/0x3c)
--
viresh
next prev parent reply other threads:[~2016-05-31 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 22:23 [PATCH] cpufreq: stats: Make the stats code non-modular Rafael J. Wysocki
2016-05-26 4:59 ` Viresh Kumar
2016-05-28 13:15 ` Rafael J. Wysocki
2016-05-30 4:53 ` Viresh Kumar
2016-05-30 13:43 ` Rafael J. Wysocki
2016-05-31 10:44 ` Viresh Kumar [this message]
2016-05-31 20:47 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531104434.GE9463@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).