From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754496AbcEaPxx (ORCPT ); Tue, 31 May 2016 11:53:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49739 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744AbcEaPxv (ORCPT ); Tue, 31 May 2016 11:53:51 -0400 Date: Tue, 31 May 2016 11:53:49 -0400 From: Mike Snitzer To: Ming Lei Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Al Viro , "open list:DRBD DRIVER" , Jan Kara , Joe Thornber , Keith Busch , Kent Overstreet , "Kirill A. Shutemov" , "Martin K. Petersen" , Michal Hocko , NeilBrown , Sagi Grimberg , Shaohua Li , Steven Whitehouse , Tejun Heo , "open list:XFS FILESYSTEM" Subject: Re: [PATCH v6 0/8] block: prepare for multipage bvecs Message-ID: <20160531155348.GA24840@redhat.com> References: <1464615294-9946-1-git-send-email-ming.lei@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464615294-9946-1-git-send-email-ming.lei@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 31 May 2016 15:53:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 30 2016 at 9:34am -0400, Ming Lei wrote: > > Hi, > > Interests[1] have been shown in multipage bvecs, so this patchset > try to prepare for the support and do two things: > > 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), > then we can drop the non-standard way for iterating bvec, which > can be thought as a good cleanup for lib/iov_iter.c > > 2) remove BIO_MAX_SECTORS and makre BIO_MAX_SIZE as obsolete, and > now there is only one user for each. Once multipage bvecs is introduced, > one bio may hold lots of sectors, and we should always use sort of > BIO_MAX_VECS which should be introduced in future and is similiar > with current BIO_MAX_PAGES. > > The only functional change is iterate_bvec():lib/iov_iter.c > > xfstests(-a auto) over loop aio is run for ext4/xfs to verify > the change and no regression found with this patchset. > > V6: > - rebased on v4.7-rc1 > - add reviewed-by tag > - mark BIO_MAX_SIZE as obsolete instead of removing because > dm-tree adds one usage now Not sure what you're referring to here with "dm-tree" (since "dm-tree" doesn't exist). But only direct user of "BIO_MAX_SIZE" in DM appears to be dm-crypt.c. Maybe you've identified some indirect use of BIO_MAX_SIZE?