From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756649AbcFABRM (ORCPT ); Tue, 31 May 2016 21:17:12 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35243 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbcFABRK (ORCPT ); Tue, 31 May 2016 21:17:10 -0400 Date: Wed, 1 Jun 2016 10:17:06 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Joonsoo Kim , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH v2 2/8] zram: switch to crypto compress API Message-ID: <20160601011706.GD461@swordfish> References: <20160531122017.2878-1-sergey.senozhatsky@gmail.com> <20160531122017.2878-3-sergey.senozhatsky@gmail.com> <20160531234431.GD19976@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160531234431.GD19976@bbox> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (06/01/16 08:44), Minchan Kim wrote: > > > trivial: > > One thing I got missed in review. > > > -int zcomp_compress(struct zcomp *comp, struct zcomp_strm *zstrm, > > - const unsigned char *src, size_t *dst_len); > > +int zcomp_compress(struct zcomp_strm *zstrm, > > + const unsigned char *src, unsigned int *dst_len); > > unsigned int for dst_len > > > > > -int zcomp_decompress(struct zcomp *comp, const unsigned char *src, > > +int zcomp_decompress(struct zcomp_strm *zstrm, > > + const unsigned char *src, > > size_t src_len, unsigned char *dst); > > > > size_t src_len? thanks for spotting it! -ss