From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932542AbcFASFo (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Jun 2016 14:05:44 -0400
Received: from mga11.intel.com ([192.55.52.93]:13672 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751624AbcFASFn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Jun 2016 14:05:43 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,402,1459839600"; 
   d="scan'208";a="966864921"
Date: Wed, 1 Jun 2016 11:05:41 -0700
From: jacob <jacob.jun.pan@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephane Eranian <eranian@google.com>,
        Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH] perf/x86/intel/rapl: add skylake server
Message-ID: <20160601110541.4e68fd1f@jacob-VB>
In-Reply-To: <20160531092908.GV3192@twins.programming.kicks-ass.net>
References: <1464107503-14968-1-git-send-email-jacob.jun.pan@linux.intel.com>
	<20160531092908.GV3192@twins.programming.kicks-ass.net>
Organization: otc
X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 31 May 2016 11:29:08 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> >  	case 63: /* Haswell-Server */
> >  	case 79: /* Broadwell-Server */
> > +	case 85: /* Skylake-Server */
> >  		apply_quirk = true;
> >  		rapl_cntr_mask = RAPL_IDX_SRV;
> >  		rapl_pmu_events_group.attrs =
> > rapl_events_srv_attr;  
> 
> This does not apply; please try against a more recent kernel. In
> specific commit:
> 
>   4b6e2571bf00 ("x86/perf/intel/rapl: Make the Intel RAPL PMU driver
> modular")
> 
> seems to the 'problem'.
Dave Hanse (cc'd) will send out the patch as part of the clean up of
open-coding x86 model numbers.