From: Andrew Morton <akpm@linux-foundation.org>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] befs: remove unused endian functions
Date: Wed, 1 Jun 2016 12:20:30 -0700 [thread overview]
Message-ID: <20160601122030.73fa60cb35a8bb4a306835bb@linux-foundation.org> (raw)
In-Reply-To: <574DFB17.5080904@osg.samsung.com>
On Tue, 31 May 2016 21:59:03 +0100 Luis de Bethencourt <luisbg@osg.samsung.com> wrote:
> On 31/05/16 21:54, Al Viro wrote:
> > On Tue, May 31, 2016 at 02:27:57PM +0100, Luis de Bethencourt wrote:
> >> Remove endianness conversion functions that are declared but never used.
> >
> > Well... As long as it stays read-only - sure, you don't need to convert
> > anything to on-disk types.
I think it would be best to leave the code as-is. The compiler will
remove it all so there's a very small amount of compile-time cost. We
could just comment the code out but then they would rot over time,
>
> Hello,
>
> While reading the BeFS book "Practical Filesystems" I have gotten really
> interested in this and it's why I am reading/learning the Linux
> implementation.
>
> The idea of adding write support has crossed my mind, but I wanted to know
> if you would be interested in this before I start looking into it. Are you?
>
> It would take some time and there are other things to clean in the befs code
> first though.
It could be a fun starter project but I have to say, befs is not a very
valuable place in which to spend your time nor is befs the best place
in which to develop familiarity. A more modest project within a more
mainstream part of the kernel would be a better investment.
next prev parent reply other threads:[~2016-06-01 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 13:27 [PATCH] befs: remove unused endian functions Luis de Bethencourt
2016-05-31 20:54 ` Al Viro
2016-05-31 20:59 ` Luis de Bethencourt
2016-06-01 19:20 ` Andrew Morton [this message]
2016-06-01 19:31 ` Luis de Bethencourt
2016-06-01 19:38 ` Andrew Morton
2016-06-01 19:44 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601122030.73fa60cb35a8bb4a306835bb@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).