linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Zhouyi Zhou <yizhouzhou@ict.ac.cn>
Cc: penberg@kernel.org, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, Zhouyi Zhou <zhouzhouyi@gmail.com>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] relay: fix potential memory leak
Date: Wed, 1 Jun 2016 14:56:49 -0700	[thread overview]
Message-ID: <20160601145649.b1ca852264601ffaa451e6d4@linux-foundation.org> (raw)
In-Reply-To: <1464777927-19675-1-git-send-email-yizhouzhou@ict.ac.cn>

On Wed,  1 Jun 2016 18:45:27 +0800 Zhouyi Zhou <yizhouzhou@ict.ac.cn> wrote:

> when relay_open_buf fails in relay_open, program will goto free_bufs,
> but chan is nowhere freed.

OK.

> In addition, give warning to users who forget to provide create file
> hook. 	 

Why?  What's the value in this?

If the user didn't provide ->create_buf_file then setup_callbacks()
will provide them with create_buf_file_default_callback() - what's
wrong with that?

  reply	other threads:[~2016-06-01 21:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01 10:45 [PATCH] relay: fix potential memory leak Zhouyi Zhou
2016-06-01 21:56 ` Andrew Morton [this message]
2016-06-02  1:24   ` Zhouyi Zhou
2016-06-02  2:11     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160601145649.b1ca852264601ffaa451e6d4@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yizhouzhou@ict.ac.cn \
    --cc=zhouzhouyi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).