From: Andrew Morton <akpm@linux-foundation.org>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, fabf@skynet.be
Subject: Re: [PATCH] befs/btree: remove unneeded initializations
Date: Wed, 1 Jun 2016 15:42:40 -0700 [thread overview]
Message-ID: <20160601154240.3bb9760d518af5bc95548016@linux-foundation.org> (raw)
In-Reply-To: <1464568799-12631-1-git-send-email-luisbg@osg.samsung.com>
On Mon, 30 May 2016 01:39:59 +0100 Luis de Bethencourt <luisbg@osg.samsung.com> wrote:
> off in befs_bt_read_node() will be written by befs_read_datastream(), with
> the value that node->od_node needs.
>
> node_off in befs_btree_read() isn't read before set to root_node_ptr.
>
> Removing these two unneeded initializations.
>
> ...
>
> --- a/fs/befs/btree.c
> +++ b/fs/befs/btree.c
> @@ -196,7 +196,7 @@ static int
> befs_bt_read_node(struct super_block *sb, const befs_data_stream *ds,
> struct befs_btree_node *node, befs_off_t node_off)
> {
> - uint off = 0;
> + uint off;
>
> befs_debug(sb, "---> %s", __func__);
>
With this code:
int foo;
bar(&foo);
whatever = foo;
some versions of gcc will warn that foo might be used uninitialized.
Other versions of gcc don't do this. That's why the seemingly-unneeded
initializations are there.
Neither of the versions of gcc which I tested with actually do warn,
but I'm inclined to leave things as-is: some people will get warnings
and that's probably worse than a couple of bytes bloat in befs.
It shouldn't cause any bloat, really. We have the "uninitialized_var"
macro which avoids any bloat and is self-documenting. And the nice
thing about self-documenting code is that it prevents Andrew from
having to explain strange code to Luis ;) But unintialized_var in
unpopular for reasons which I personally find unpersuasive, given
the advantages...
next prev parent reply other threads:[~2016-06-01 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 0:39 [PATCH] befs/btree: remove unneeded initializations Luis de Bethencourt
2016-06-01 22:42 ` Andrew Morton [this message]
2016-06-01 23:43 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601154240.3bb9760d518af5bc95548016@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).