From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756005AbcFARqc (ORCPT ); Wed, 1 Jun 2016 13:46:32 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:42470 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752901AbcFARqa (ORCPT ); Wed, 1 Jun 2016 13:46:30 -0400 Date: Wed, 1 Jun 2016 19:46:25 +0200 From: Peter Zijlstra To: Dave Hansen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, dave.hansen@linux.intel.com, ak@linux.intel.com, kan.liang@intel.com Subject: Re: [PATCH 2/5] x86, perf: use Intel family macros for core perf events Message-ID: <20160601174625.GP3206@twins.programming.kicks-ass.net> References: <20160601173440.4BF4BE10@viggo.jf.intel.com> <20160601173442.1E440C8B@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160601173442.1E440C8B@viggo.jf.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 01, 2016 at 10:34:42AM -0700, Dave Hansen wrote: > > From: Dave Hansen > > Use the new model number macros instead of spelling things out > in the comments. > > Note that this is missing a Nehalem model that is mentioned in > intel_idle. Is that a a problem? Would be good to add fix up; maybe a follow up patch that fixes up all the missing entires for all 4 lists as 6/5 ?