From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751985AbcFBHKY (ORCPT <rfc822;w@1wt.eu>);
	Thu, 2 Jun 2016 03:10:24 -0400
Received: from mail-pf0-f193.google.com ([209.85.192.193]:34307 "EHLO
	mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750744AbcFBHKX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 2 Jun 2016 03:10:23 -0400
Date: Thu, 2 Jun 2016 16:10:17 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Geliang Tang <geliangtang@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] mm/zsmalloc: remove unused header cpumask.h
Message-ID: <20160602071017.GA439@swordfish>
References: <7cc1b41351a96e7d67fcf4bd2a6987b71793cb27.1464847139.git.geliangtang@gmail.com>
 <f0fa3738403f886988141182e8e4bac7efed05c7.1464847139.git.geliangtang@gmail.com>
 <866efd744a89b6e16c9d3acd1a00b011adbd59af.1464847139.git.geliangtang@gmail.com>
 <94e9f6fee719fcaa91ee5767a9ad64658c6f5237.1464847139.git.geliangtang@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <94e9f6fee719fcaa91ee5767a9ad64658c6f5237.1464847139.git.geliangtang@gmail.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (06/02/16 14:15), Geliang Tang wrote:
> Remove unused header cpumask.h from mm/zsmalloc.c.
> 
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
>  mm/zsmalloc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index b6d4f25..a93327e 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -57,7 +57,6 @@
>  #include <linux/slab.h>
>  #include <asm/tlbflush.h>
>  #include <asm/pgtable.h>
> -#include <linux/cpumask.h>
>  #include <linux/cpu.h>
>  #include <linux/vmalloc.h>
>  #include <linux/preempt.h>

NAK. I don't think it's "unused".

zs_register_cpu_notifier()
	for_each_online_cpu()


which is coming from include/linux/cpumask.h

#define for_each_online_cpu(cpu)   for_each_cpu((cpu), cpu_online_mask)

	-ss