linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [RFC 0/4] Intel Integrated Sensor Hub Support (ISH)
@ 2016-06-02 14:35 me
  0 siblings, 0 replies; 18+ messages in thread
From: me @ 2016-06-02 14:35 UTC (permalink / raw)
  To: linux-kernel

Hello,

My thanks to you and your team for releasing this patch to get the sensor
hubs up and running on Linux machines.

I've compiled a new kernel with the patches you've provided, but it appears
that it's not being detected just yet. I have a Thinkpad 460 Yoga that I'm
testing on.

 From the compile log for the custom kernel:

  CC      drivers/hid/intel-ish-hid/ipc/pci-ish.o
  CC      fs/proc/vmcore.o
  CC [M]  net/netfilter/xt_TCPOPTSTRIP.o
  CC [M]  drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.o
  CC      drivers/hid/intel-ish-hid/ishtp-hid.o
  CC [M]  net/rds/connection.o
  CC [M]  net/netfilter/xt_TEE.o
  CC      fs/proc/kmsg.o
  CC      drivers/hid/intel-ish-hid/ishtp-hid-client.o
  CC      fs/proc/page.o
  CC [M]  drivers/gpu/drm/amd/amdgpu/amdgpu_powerplay.o

  LD      drivers/hid/intel-ish-hid/intel-ishtp.o
  LD      drivers/hid/intel-ish-hid/intel-ish-ipc.o
  LD      drivers/hid/intel-ish-hid/intel-ishtp-hid.o
  LD      drivers/hid/intel-ish-hid/built-in.o
  LD      drivers/hid/usbhid/built-in.o
  CC [M]  drivers/hid/usbhid/hid-core.o

  LD      fs/proc/proc.o
  LD      fs/proc/built-in.o
  CC      fs/pstore/inode.o
  CC [M]  net/netfilter/xt_TRACE.o
  CC [M]  drivers/gpu/drm/amd/amdgpu/cz_smc.o
  CC [M]  net/rds/info.o
  CC [M]  net/netfilter/xt_IDLETIMER.o
  CC      fs/pstore/platform.o
  CC [M]  drivers/hid/usbhid/hid-quirks.o

 From lspci -vvvnn:

00:13.0 Non-VGA unclassified device [0000]: Intel Corporation Device
[8086:9d35] (rev 21)
        Subsystem: Lenovo Device [17aa:504c]
        Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx-
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
        Interrupt: pin A routed to IRQ 255
        Region 0: Memory at d564b000 (64-bit, non-prefetchable)
[disabled] [size=4K]
        Capabilities: [80] Power Management version 3
                Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
                Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0
PME-

not much mention from dmesg unfortunately when checking for the hardware
id:

[    0.453834] pci 0000:00:13.0: [8086:9d35] type 00 class 0x000000
[    0.453853] pci 0000:00:13.0: reg 0x10: [mem 0xd564b000-0xd564bfff
64bit]

Please let me know what other information I can provide to help narrow the
issue down, or if there's something that I may be doing incorrectly.

Thanks!

Daniel Turton

^ permalink raw reply	[flat|nested] 18+ messages in thread
* [RFC 0/4] Intel Integrated Sensor Hub Support (ISH)
@ 2016-05-31  4:27 Srinivas Pandruvada
  2016-06-01 13:36 ` Atri Bhattacharya
  2016-06-09 21:45 ` Grant Likely
  0 siblings, 2 replies; 18+ messages in thread
From: Srinivas Pandruvada @ 2016-05-31  4:27 UTC (permalink / raw)
  To: jikos, benjamin.tissoires, jic23
  Cc: linux-input, linux-iio, linux-kernel, chaya.golan, daniel.drubin,
	Srinivas Pandruvada

Starting from Cherrytrail, multiple generation of Intel processors offers
on package sensor hub. Several recent tablets, 2-in-1 convertible laptops
are using ISH instead of external sensor hubs. This resulted in lack of
support of sensor function like device rotation and auto backlight
adjustment. In addition, depending on the OEM implementation, support of ISH
is required to support low power sleep states.

The support of ISH on Linux platforms is not new. Android platforms with
Intel SoCs had this support for a while submitted by Daniel Drubin. 
This patcheset is reusing most of those changes with  clean up and
removing Android platform specific changes.

This series is tested on:
- Lenovo Yoga 260 with Skylake processor
- HP Pavilion x2 detachable with Cherrytrail 

The user mode ABI is still same as external sensor hubs using Linux
IIO. So existing user mode software should still work without change.
This series primarily brings in new HID transport used in ISH.

This series submitted as a RFC to try on several devices. We have 
received request from Linux users who wanted this support. So I hope all
those users try and give feedback.

Daniel Drubin (3):
  hid: intel_ish-hid: ISH Transport layer
  hid: intel-ish-hid: ipc layer
  hid: intel-ish-hid: ISH HID client driver

Srinivas Pandruvada (1):
  Documentation: hid: Intel ISH HID document

 Documentation/hid/intel-ish-hid.txt          |  375 +++++++++
 drivers/hid/Kconfig                          |    2 +
 drivers/hid/Makefile                         |    2 +
 drivers/hid/intel-ish-hid/Kconfig            |   27 +
 drivers/hid/intel-ish-hid/Makefile           |   20 +
 drivers/hid/intel-ish-hid/ipc/hw-ish-regs.h  |  220 +++++
 drivers/hid/intel-ish-hid/ipc/hw-ish.h       |   71 ++
 drivers/hid/intel-ish-hid/ipc/ipc.c          |  710 ++++++++++++++++
 drivers/hid/intel-ish-hid/ipc/pci-ish.c      |  238 ++++++
 drivers/hid/intel-ish-hid/ipc/utils.h        |   65 ++
 drivers/hid/intel-ish-hid/ishtp-hid-client.c |  672 +++++++++++++++
 drivers/hid/intel-ish-hid/ishtp-hid.c        |  201 +++++
 drivers/hid/intel-ish-hid/ishtp-hid.h        |  157 ++++
 drivers/hid/intel-ish-hid/ishtp/bus.c        |  670 +++++++++++++++
 drivers/hid/intel-ish-hid/ishtp/bus.h        |   99 +++
 drivers/hid/intel-ish-hid/ishtp/client.c     | 1131 ++++++++++++++++++++++++++
 drivers/hid/intel-ish-hid/ishtp/client.h     |  196 +++++
 drivers/hid/intel-ish-hid/ishtp/dma-if.c     |  175 ++++
 drivers/hid/intel-ish-hid/ishtp/hbm.c        |  911 +++++++++++++++++++++
 drivers/hid/intel-ish-hid/ishtp/hbm.h        |  319 ++++++++
 drivers/hid/intel-ish-hid/ishtp/init.c       |   94 +++
 drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h  |  276 +++++++
 include/trace/events/intel_ish.h             |   30 +
 23 files changed, 6661 insertions(+)
 create mode 100644 Documentation/hid/intel-ish-hid.txt
 create mode 100644 drivers/hid/intel-ish-hid/Kconfig
 create mode 100644 drivers/hid/intel-ish-hid/Makefile
 create mode 100644 drivers/hid/intel-ish-hid/ipc/hw-ish-regs.h
 create mode 100644 drivers/hid/intel-ish-hid/ipc/hw-ish.h
 create mode 100644 drivers/hid/intel-ish-hid/ipc/ipc.c
 create mode 100644 drivers/hid/intel-ish-hid/ipc/pci-ish.c
 create mode 100644 drivers/hid/intel-ish-hid/ipc/utils.h
 create mode 100644 drivers/hid/intel-ish-hid/ishtp-hid-client.c
 create mode 100644 drivers/hid/intel-ish-hid/ishtp-hid.c
 create mode 100644 drivers/hid/intel-ish-hid/ishtp-hid.h
 create mode 100644 drivers/hid/intel-ish-hid/ishtp/bus.c
 create mode 100644 drivers/hid/intel-ish-hid/ishtp/bus.h
 create mode 100644 drivers/hid/intel-ish-hid/ishtp/client.c
 create mode 100644 drivers/hid/intel-ish-hid/ishtp/client.h
 create mode 100644 drivers/hid/intel-ish-hid/ishtp/dma-if.c
 create mode 100644 drivers/hid/intel-ish-hid/ishtp/hbm.c
 create mode 100644 drivers/hid/intel-ish-hid/ishtp/hbm.h
 create mode 100644 drivers/hid/intel-ish-hid/ishtp/init.c
 create mode 100644 drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h
 create mode 100644 include/trace/events/intel_ish.h

-- 
1.9.1

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2016-06-14 21:34 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-02 14:35 [RFC 0/4] Intel Integrated Sensor Hub Support (ISH) me
  -- strict thread matches above, loose matches on Subject: below --
2016-05-31  4:27 Srinivas Pandruvada
2016-06-01 13:36 ` Atri Bhattacharya
2016-06-09 21:45 ` Grant Likely
2016-06-09 21:54   ` Srinivas Pandruvada
2016-06-10  9:44     ` Grant Likely
2016-06-10 13:55       ` Srinivas Pandruvada
2016-06-10 14:26         ` Bastien Nocera
2016-06-10 14:45           ` Srinivas Pandruvada
2016-06-10 15:04             ` Bastien Nocera
2016-06-10 15:23               ` Srinivas Pandruvada
2016-06-10 15:27                 ` Bastien Nocera
2016-06-14 13:44                   ` Grant Likely
2016-06-14 15:12                     ` Bastien Nocera
2016-06-14 16:08                       ` Grant Likely
2016-06-14 17:01                         ` Bastien Nocera
2016-06-14 21:33                           ` Grant Likely
2016-06-10 14:02       ` Grant Likely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).